tiny-AES-c icon indicating copy to clipboard operation
tiny-AES-c copied to clipboard

Published 20 hours ago • verified publisher icon kokke

#define AES_KEYLEN bites with SAMD5 compiler

Open vogt31337 opened this issue 6 years ago • 4 comments

Hi,

your tiny AES works flawlessly on an Arduino Feather M4 Express (AVR SAMD5 architecture). But the #define AES_KEYLEN get's redefined in the include files from the compiler. The SAMD5 has a hardware AES module and defines it's own AES_KEYLEN.

So maybe rename some things in this library?

BR

vogt31337 avatar Feb 14 '19 12:02 vogt31337

This would be the sort of thing that namespaces and static constexpr are designed to gracefully sidestep...

Rgds

Damon

DamonHD avatar Feb 14 '19 13:02 DamonHD

I don't know maybe. But when I include tiny-AES-c the compiler complains. And I thought changing the compiler delivered includes wouldn't be the right spot...

vogt31337 avatar Feb 28 '19 12:02 vogt31337

Hi @vogt31337 and thanks for your interest in this project.

As I usually do, I agree with @DamonHD on this point.

So maybe rename some things in this library?

I'll be happy to review a PR with any naming changes you could have in mind :)

kokke avatar Mar 18 '19 22:03 kokke

I also agree with @DamonHD, but I don't have enough time / knowledge to implement this. So as a matter of fact I would just change the name to something like TINY_AES_KEYLEN...

vogt31337 avatar Mar 21 '19 09:03 vogt31337