nbviewer.js icon indicating copy to clipboard operation
nbviewer.js copied to clipboard

Visual testing

Open kokes opened this issue 5 years ago • 1 comments

Since it's quite hard to build proper tests (see #33), we can start by having non-automated visual tests. What I envisage the workflow to be:

  1. Take screenshots of various notebooks in nbviewer.js
  2. Work on whatever changes you want
  3. Take the same screenshots again
  4. Use something like pixelmatch to diff these

What we need in terms of infrastructure:

  • [ ] sample notebooks, versioned
  • [ ] a way to offer inject a notebook into the viewer (maybe we'll have a separate HTML file for testing, without the dropzone stuff)
  • [ ] some code to automate the screenshot taking and diffing

kokes avatar Feb 08 '20 13:02 kokes

wip: https://github.com/kokes/nbviewer.js/tree/issue41

kokes avatar Feb 08 '20 14:02 kokes