nbviewer.js icon indicating copy to clipboard operation
nbviewer.js copied to clipboard

Support exactly one cell output

Open kokes opened this issue 6 years ago • 1 comments

As discovered in #28, we sometimes render multiple cell outputs, but we should always render just one. There is an ordering defined in nbconvert, so we should check each when parsing the data field.

Before implementing this

  1. let's check a few notebooks (from tests, see #33) and how they render before and after.
  2. see if we can implement some of the mime types that are not yet supported (e.g. application/pdf?)
  3. grep as many notebooks as possible and check their mime types - maybe there our some extra mime types out there

kokes avatar Feb 10 '19 16:02 kokes

We're now rendering at most one cell output (https://github.com/kokes/nbviewer.js/commit/255fc3e9e44e4697d007738409ca8431c78608d0) and I've checked it all against the tests in nbformat and nbconvert, but I have yet to resolve the other points in this issue.

kokes avatar Feb 10 '19 17:02 kokes