nbviewer.js icon indicating copy to clipboard operation
nbviewer.js copied to clipboard
verified publisher icon kokes

Build regression tests and a harness

Open kokes opened this issue 6 years ago • 2 comments

I'm not sure what the best course of action here is. Whether we should just care about DOM generation or if we should go full "screenshot testing" - using Selenium or Puppeteer.

The main reason is to test things like overflows in pres and imgs, multiple outputs, legacy versions etc. Things that tend to break with changes to the library code.

kokes avatar Feb 09 '19 19:02 kokes

We could also leverage the nbformat and nbconvert tests

  • https://github.com/jupyter/nbformat/tree/master/nbformat/tests
  • https://github.com/jupyter/nbconvert/tree/master/nbconvert/tests/files

kokes avatar Feb 10 '19 15:02 kokes

This commit https://github.com/kokes/nbviewer.js/commit/36c745d6a5a4fc6f8b25ba3a20695c1cdfb469c3 could be tested for regressions using https://github.com/jupyter/nbconvert/blob/master/nbconvert/tests/files/notebook1.ipynb

kokes avatar Feb 10 '19 16:02 kokes