Joonas Koivunen

Results 155 comments of Joonas Koivunen

Ack, going through the diff now.

> I'm not sure what is causing them, but I have seen them sometimes. Sometimes even during the setup stage. I think these are normal s3 being s3 errors. With...

`nextest` would have retries for flaky tests: . Running azure and s3 tests with retries might work. (Did not check if they are already configured.) However what has changed..? Introduction...

I cannot say I like this even if it's already approved, the direction I was nudging towards with the triplet matching felt much better. Feels like there must be a...

Last week: - Refactoring PR no. 2 was released - Arseny found a bug related to refactoring PR, it was fixed https://github.com/neondatabase/neon/issues/7967 This week: - need to create the last...

> So, I think `secondary_tenant.evict_layer()` has probably not been audited for cancellation safety. Excellent point. This PR was done before secondary tenants or at least their eviction, and I did...

> Not sure why you went for a `timeout` parameter instead of making callers who care use `tokio::time::timeout`, but 🤷 I was thinking it's the mandatory nature makes sense here....