sd-scripts icon indicating copy to clipboard operation
sd-scripts copied to clipboard

lr_schedulers currently do not take in num_cycles or power parameters

Open mgz-dev opened this issue 2 years ago • 1 comments

Current version of diffusers.optimization.get_scheduler used does not expose power parameter (for polynomial) or num_cycles (for cosine_with_restarts).

This means, for example:

  • the current implementation of cosine, and cosine_with_restarts produce the same scheduler as the num_cycles defaults to 1.
  • the current implementation of polynomial only produces a linear scheduler as the power defaults to 1.

This is fixed in a future implementation of diffusers: https://github.com/huggingface/diffusers/commit/d87cc15977b87160c30abaace3894e802ad9e1e6#diff-8702f762e46a3b5363085930b0b045de554909d32560864031ca7b12ddd349d5

Posting this as an issue for awareness and also as something to look into in the future if the repo is tested and updated for a later version of diffusers which includes this patch from the above diffusers commit.

mgz-dev avatar Jan 18 '23 20:01 mgz-dev

+1

smolkat64 avatar Jan 20 '23 10:01 smolkat64