click icon indicating copy to clipboard operation
click copied to clipboard

fix invalid type error on systems with HAVE_VA_LIST_AS_ARRAY

Open asmuth opened this issue 8 years ago • 3 comments

fixes #336

asmuth avatar Apr 05 '17 17:04 asmuth

I'm confused. Where does HAVE_VA_LIST_AS_ARRAY come from? It's not something we define.

I'm worried that the type error actually represents a problem.

kohler avatar Jun 28 '17 12:06 kohler

The CLICK_CHECK_ADDRESSABLE_VA_LIST configury step is supposed to detect this problem, and then leave HAVE_ADDRESSABLE_VA_LIST undefined.

kohler avatar Jun 28 '17 12:06 kohler

The problem came up a while back when trying to build click inside of a bitbake/yocto toolchain.

I did not realize there was already a check for this condition and added the HAVE_VA_LIST_AS_ARRAY ifdef (which seemed semi-standard, at least mozilla central and rpm use it) as a quick local patch and built with -DHAVE_VA_LIST_AS_ARRAY to work around the issue.

Of course if there already is a proper configure-time check for this, that should be used instead. I'll try debugging later/tomorrow why the CLICK_CHECK_ADDRESSABLE_VA_LIST did not work as intended inside of our cross toolchain.

asmuth avatar Jun 28 '17 12:06 asmuth