cppcheck issues

[setharnold]

Hello, cppcheck reports some issues with the current codebase; these might be issues that are otherwise hard to track down, or might be entirely harmless, just odd:

command2foo2lava-pjl.c:413:31: error: Undefined behavior: Variable 'buffer' is used as parameter and destination in sprintf(). [sprintfOverlappingData]
     sprintf(buffer, "%s,%s", buffer, supplies[k].type);
                              ^
command2foo2lava-pjl.c:423:40: error: Undefined behavior: Variable 'buffer' is used as parameter and destination in sprintf(). [sprintfOverlappingData]
  sprintf(buffer, "%s\"%s (Max %d)\"", buffer, supplies[k].name,
                                       ^
command2foo2lava-pjl.c:426:31: error: Undefined behavior: Variable 'buffer' is used as parameter and destination in sprintf(). [sprintfOverlappingData]
  sprintf(buffer, "%s\"%s\"", buffer, supplies[k].name);
                              ^
command2foo2lava-pjl.c:433:31: error: Undefined behavior: Variable 'buffer' is used as parameter and destination in sprintf(). [sprintfOverlappingData]
     sprintf(buffer, "%s,%s", buffer, supplies[k].color);
                              ^
command2foo2lava-pjl.c:439:31: error: Undefined behavior: Variable 'buffer' is used as parameter and destination in sprintf(). [sprintfOverlappingData]
     sprintf(buffer, "%s,%d", buffer, supplies[k].level);
                              ^
foo2lava.c:1685:15: error: Uninitialized variable: media [uninitvar]
 rc = fwrite(&media, 1, sizeof(4), EvenPages);
              ^
icc2ps/cmscam02.c:458:22: error: Uninitialized struct member: clr.a [uninitStructMember]
    clr = XYZtoCAT02(clr);
                     ^
icc2ps/cmscam02.c:458:22: error: Uninitialized struct member: clr.b [uninitStructMember]
    clr = XYZtoCAT02(clr);
                     ^
icc2ps/cmscam02.c:458:22: error: Uninitialized struct member: clr.h [uninitStructMember]
    clr = XYZtoCAT02(clr);
                     ^
icc2ps/cmscam02.c:458:22: error: Uninitialized struct member: clr.e [uninitStructMember]
    clr = XYZtoCAT02(clr);
                     ^
icc2ps/cmscam02.c:458:22: error: Uninitialized struct member: clr.H [uninitStructMember]
    clr = XYZtoCAT02(clr);
                     ^
icc2ps/cmscam02.c:458:22: error: Uninitialized struct member: clr.A [uninitStructMember]
    clr = XYZtoCAT02(clr);
                     ^
icc2ps/cmscam02.c:458:22: error: Uninitialized struct member: clr.J [uninitStructMember]
    clr = XYZtoCAT02(clr);
                     ^
icc2ps/cmscam02.c:458:22: error: Uninitialized struct member: clr.Q [uninitStructMember]
    clr = XYZtoCAT02(clr);
                     ^
icc2ps/cmscam02.c:458:22: error: Uninitialized struct member: clr.s [uninitStructMember]
    clr = XYZtoCAT02(clr);
                     ^
icc2ps/cmscam02.c:458:22: error: Uninitialized struct member: clr.t [uninitStructMember]
    clr = XYZtoCAT02(clr);
                     ^
icc2ps/cmscam02.c:458:22: error: Uninitialized struct member: clr.C [uninitStructMember]
    clr = XYZtoCAT02(clr);
                     ^
icc2ps/cmscam02.c:458:22: error: Uninitialized struct member: clr.M [uninitStructMember]
    clr = XYZtoCAT02(clr);
                     ^
icc2ps/cmscam02.c:479:29: error: Uninitialized struct member: clr.a [uninitStructMember]
    clr = InverseCorrelates(clr, lpMod);
                            ^
icc2ps/cmscam02.c:479:29: error: Uninitialized struct member: clr.b [uninitStructMember]
    clr = InverseCorrelates(clr, lpMod);
                            ^
icc2ps/cmscam02.c:479:29: error: Uninitialized struct member: clr.e [uninitStructMember]
    clr = InverseCorrelates(clr, lpMod);
                            ^
icc2ps/cmscam02.c:479:29: error: Uninitialized struct member: clr.H [uninitStructMember]
    clr = InverseCorrelates(clr, lpMod);
                            ^
icc2ps/cmscam02.c:479:29: error: Uninitialized struct member: clr.A [uninitStructMember]
    clr = InverseCorrelates(clr, lpMod);
                            ^
icc2ps/cmscam02.c:479:29: error: Uninitialized struct member: clr.Q [uninitStructMember]
    clr = InverseCorrelates(clr, lpMod);
                            ^
icc2ps/cmscam02.c:479:29: error: Uninitialized struct member: clr.s [uninitStructMember]
    clr = InverseCorrelates(clr, lpMod);
                            ^
icc2ps/cmscam02.c:479:29: error: Uninitialized struct member: clr.t [uninitStructMember]
    clr = InverseCorrelates(clr, lpMod);
                            ^
icc2ps/cmscam02.c:479:29: error: Uninitialized struct member: clr.M [uninitStructMember]
    clr = InverseCorrelates(clr, lpMod);
                            ^
icc2ps/icc34.h:154:9: error: syntax error [syntaxError]
typedef @UINT8_T@ icUInt8Number;

(Probably that last one can be ignored. cppcheck is neat, but not perfect.)

Thanks