kite icon indicating copy to clipboard operation
kite copied to clipboard

kontrol: new signature for getKites()

Open humanchimp opened this issue 10 years ago • 1 comments

on the kite.js side, we're doing:

ok = k.tell('getKites', [query, changesHandler]);

I think we want to get rid of these positional parameters (or at least avoid them). I would like it if the signature changes to this:

ok = k.tell('getKites', [{ query, onChange }]);

And once we do https://github.com/koding/kite.js/issues/2, we can remove the extra array wrapper:

ok = k.tell('getKites', { query, onChange });

I am open for suggestions, but for the time being I've chosen the name onChange. The name is not important to me, but I would like to move away from positional parameters.

humanchimp avatar Mar 14 '14 04:03 humanchimp

I will do this after #14

cenkalti avatar Apr 04 '14 18:04 cenkalti