dumb icon indicating copy to clipboard operation
dumb copied to clipboard

Duplicate filenames on the playlist

Open druellan opened this issue 6 years ago • 9 comments

Hi! I'm having an issue with the 2.0.2 version of the component and Foobar 1.3.17

Seems that some mods are added twice to the playlist, for example: 2018-01-10_12h25_42 LIVING.zip

The MOD file plays OK, but since it is an old module from the DOS era that survived many HD, CAN have some kind of corruption in it. Anyway, perhaps some kind of extra-check while adding mods can be implemented to improve this?

Thanks!

druellan avatar Jan 10 '18 15:01 druellan

Unplayed subsongs. Ignore or delete them if they're incorrect.

kode54 avatar Jan 10 '18 21:01 kode54

Thanks for the reply. The problem is that on a long playlist they can become very annoying, or difficult to spot if you have only a couple of them. The "remove duplicates" command does not affect them.

I'm also testing OpenMPT with the same results:

2018-01-11_15h48_12

This two files are interesting. Both seems created using MilkyTracker, and they have a lot of subsongs in them MilkyPlayer.zip

druellan avatar Jan 11 '18 19:01 druellan

You can search for them with playlist search, using a query string which matches both %_subsong% greater than 0, and play time less than 10 seconds or so.

kode54 avatar Jan 11 '18 23:01 kode54

If kode54 considers this correct behavior of DUMB, maybe file the issue against Foobar?

Subsongs of 0 seconds, or even shorter than 10 seconds, look like technical artifacts rather than an intended subsong. But I can't make this judgement for kode54 because I know almost nothing about the module internals.

On the other hand, Shared Dig has 3 subsongs, all of length > 10 seconds, you might want those in the UI? First song is 2:xx long, all 3 subsongs together are 5:xx long.

SimonN avatar Jan 12 '18 00:01 SimonN

Another interesting one with more than 100 subsongs

badapple.zip

druellan avatar Jan 12 '18 00:01 druellan

I'm still trying to find a legitimate use of the subsong, and I think it is something that must be related to the tracker more than the player itself, but again, I have no insight into this matter. The only thing I can state is that from a selection of more than 1.000 MODs from modarchive.org, several have subsongs, all of them leftovers that are not part of the song.

druellan avatar Jan 12 '18 00:01 druellan

It is related to a limited quantity of modules which legitimately contain playable music on unplayed orders.

kode54 avatar Jan 12 '18 00:01 kode54

@kode54 ops! yes, posted the message incomplete by mistake, I've edited it.

druellan avatar Jan 12 '18 00:01 druellan

For instance, Sphenx's Bubbles.it has leftovers that are a legitimate subsong, an unplayed region that is more than a minute long. It also decodes really slowly in foo_dumb, but reasonably fast in foo_openmpt.

kode54 avatar Jan 12 '18 00:01 kode54