nft-gallery icon indicating copy to clipboard operation
nft-gallery copied to clipboard

Bulma conflicting with Tailwind classes

Open hassnian opened this issue 11 months ago • 7 comments

checked and the important heremd:!my-0 seems to be needed. but the others w-full h-[1px] md:w-[1px] md:h-[13px] seem to work as expect without ! pls remove any important if they are not needed.

It's not needed if there is only tailwind, but now there are some side effects from Bulma styles.. It dose not work as expected without !

yep I'm aware of that, it's pretty annoying, I've encounter those pretty often when adding anymargin or padding class , it forces you to use ! otherwise it ends up using the bulma class.

conflicting

  • padding
  • margin
  • container
  • and probably much more

Originally posted by @hassnian in https://github.com/kodadot/nft-gallery/pull/9964#discussion_r1549733655

hassnian avatar Apr 04 '24 09:04 hassnian

this is larger then it may seem

removing bulma/helpers/spacing is simple

but doing so breaks style in subtle ways

it will require going page by page and over all Neo components to make sure all stays in place

daiagi avatar Apr 11 '24 11:04 daiagi

👋

leo-1228 avatar May 09 '24 16:05 leo-1228

@leo-1228

i recommend you start with other, smaller issue this one is big and not a good choice as first issue

daiagi avatar May 10 '24 12:05 daiagi

I know, But, i will do my best for our project.

leo-1228 avatar May 11 '24 14:05 leo-1228

I checked all components and pages and removed unnecessary !,I tried to send pull request but it did not work. I think it is because changed codes is not so much to merge. image I am waiting for your reply.

leo-1228 avatar May 13 '24 11:05 leo-1228

that is not the point of the issue

by removing ! margins have changed

the ! is there to force tailwind style over bulma, without it bulma takes over. and that is the undesired behavior

to solve this it will require a. very selectively import bulma sass files (instead of importing all of them as it is now) b. slowly and carefully fixing all the broken styles that will popup

i am marking internal-only i appreciate your time spent on this @leo-1228 . but this is task is not suitable for first time

daiagi avatar May 13 '24 12:05 daiagi

ok, daiagi, sorry for failing my first contribute for our project. Now, I am going to try fixing another issue.

leo-1228 avatar May 13 '24 12:05 leo-1228