nft-gallery
nft-gallery copied to clipboard
Bulma conflicting with Tailwind classes
checked and the important here
md:!my-0
seems to be needed. but the othersw-full h-[1px] md:w-[1px] md:h-[13px]
seem to work as expect without!
pls remove any important if they are not needed.It's not needed if there is only tailwind, but now there are some side effects from Bulma styles.. It dose not work as expected without
!
yep I'm aware of that, it's pretty annoying, I've encounter those pretty often when adding anymargin
or padding
class , it forces you to use !
otherwise it ends up using the bulma class.
conflicting
- padding
- margin
- container
- and probably much more
Originally posted by @hassnian in https://github.com/kodadot/nft-gallery/pull/9964#discussion_r1549733655
this is larger then it may seem
removing bulma/helpers/spacing is simple
but doing so breaks style in subtle ways
it will require going page by page and over all Neo
components to make sure all stays in place
👋
@leo-1228
i recommend you start with other, smaller issue this one is big and not a good choice as first issue
I know, But, i will do my best for our project.
I checked all components and pages and removed unnecessary !,I tried to send pull request but it did not work.
I think it is because changed codes is not so much to merge.
I am waiting for your reply.
that is not the point of the issue
by removing !
margins have changed
the !
is there to force tailwind style over bulma, without it bulma takes over. and that is the undesired behavior
to solve this it will require a. very selectively import bulma sass files (instead of importing all of them as it is now) b. slowly and carefully fixing all the broken styles that will popup
i am marking internal-only
i appreciate your time spent on this @leo-1228 . but this is task is not suitable for first time
ok, daiagi, sorry for failing my first contribute for our project. Now, I am going to try fixing another issue.