nft-gallery icon indicating copy to clipboard operation
nft-gallery copied to clipboard

fix: transfer page buttons alignment

Open iMac7 opened this issue 1 year ago โ€ข 10 comments

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

๐Ÿ‘‡ __ Let's make a quick check before the contribution.

PR Type

  • [x] Bugfix
  • [ ] Feature
  • [ ] Refactoring

Context

  • [ ] Closes #9530
  • [ ] Requires deployment <snek/rubick/worker>

Before submitting pull request, please make sure:

  • [ ] My contribution builds clean without any errors or warnings
  • [ ] I've merged recent default branch -- main and I've no conflicts
  • [ ] I've tried to respect high code quality standards
  • [ ] I've didn't break any original functionality

Optional

  • [ ] I've tested it at </ksm/collection>
  • [ ] I've tested PR on mobile
  • [ ] I've written unit tests ๐Ÿงช
  • [ ] I've found edge cases

Did your issue had any of the "$" label on it?

  • [x] Fill up your DOT address: Payout

Community participation

Screenshot ๐Ÿ“ธ

  • [x] My fix has changed something on UI; a screenshot is best to understand changes for others. Screenshot_20240223_085434

iMac7 avatar Feb 23 '24 05:02 iMac7

SUCCESS @iMac7 PR for issue #9530 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

kodabot avatar Feb 23 '24 05:02 kodabot

Deploy Preview for koda-canary ready!

Name Link
Latest commit 87e2b63140e6a31eec400bd7d0cb34eeddd8f263
Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/65ddc229443cef0007f5788e
Deploy Preview https://deploy-preview-9531--koda-canary.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Feb 23 '24 05:02 netlify[bot]

@iMac7 pls also center the content

hassnian avatar Feb 23 '24 06:02 hassnian

done

iMac7 avatar Feb 23 '24 07:02 iMac7

the root cause of the issue , some other buttons might also be broken

CleanShot 2024-02-23 at 17 16 22@2x

Maybe we should fix the root issue instead of adding a fix every place. It's should be the same bug like #9539 image

Jarsen136 avatar Feb 23 '24 22:02 Jarsen136

the root cause of the issue , some other buttons might also be broken

CleanShot 2024-02-23 at 17 16 22@2x

nice catch, any reason it might have been commented out? I hope undoing this doesn't break anything :eyes:

iMac7 avatar Feb 24 '24 06:02 iMac7

@iMac7 check any pill variant used inside that pr and see if you can add a local fix there

hassnian avatar Feb 24 '24 06:02 hassnian

@iMac7 check any pill variant used inside that pr and see if you can add a local fix there Just uncommenting this seems to fix things, are you suggesting I leave the comment as it is and apply local fixes on the pill buttons?

iMac7 avatar Feb 25 '24 14:02 iMac7

Code Climate has analyzed commit 87e2b631 and detected 0 issues on this pull request.

View more on Code Climate.

codeclimate[bot] avatar Feb 27 '24 11:02 codeclimate[bot]

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Feb 27 '24 11:02 sonarqubecloud[bot]

Oh yes. I commented that line out It was causing wierd behviour on code Checker pill variant buttons

So whatever fix is. Please check that buttons over there stay centered Pay attention to button that have icon as well

https://canary.kodadot.xyz/code-checker

daiagi avatar Feb 27 '24 11:02 daiagi

Oh yes. I commented that line out It was causing wierd behviour on code Checker pill variant buttons

So whatever fix is. Please check that buttons over there stay centered Pay attention to button that have icon as well

https://canary.kodadot.xyz/code-checker

it was happening on the pill variants, any style that overrides a similar style in NeoButton.scss is not applied

iMac7 avatar Feb 27 '24 11:02 iMac7