nft-gallery
nft-gallery copied to clipboard
fix: transfer page buttons alignment
Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.
๐ __ Let's make a quick check before the contribution.
PR Type
- [x] Bugfix
- [ ] Feature
- [ ] Refactoring
Context
- [ ] Closes #9530
- [ ] Requires deployment <snek/rubick/worker>
Before submitting pull request, please make sure:
- [ ] My contribution builds clean without any errors or warnings
- [ ] I've merged recent default branch -- main and I've no conflicts
- [ ] I've tried to respect high code quality standards
- [ ] I've didn't break any original functionality
Optional
- [ ] I've tested it at </ksm/collection>
- [ ] I've tested PR on mobile
- [ ] I've written unit tests ๐งช
- [ ] I've found edge cases
Did your issue had any of the "$" label on it?
- [x] Fill up your DOT address: Payout
Community participation
Screenshot ๐ธ
- [x] My fix has changed something on UI; a screenshot is best to understand changes for others.
SUCCESS @iMac7 PR for issue #9530 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!
Deploy Preview for koda-canary ready!
Name | Link |
---|---|
Latest commit | 87e2b63140e6a31eec400bd7d0cb34eeddd8f263 |
Latest deploy log | https://app.netlify.com/sites/koda-canary/deploys/65ddc229443cef0007f5788e |
Deploy Preview | https://deploy-preview-9531--koda-canary.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
@iMac7 pls also center the content
done
the root cause of the issue , some other buttons might also be broken
Maybe we should fix the root issue instead of adding a fix every place.
It's should be the same bug like #9539
the root cause of the issue , some other buttons might also be broken
nice catch, any reason it might have been commented out? I hope undoing this doesn't break anything :eyes:
@iMac7 check any pill variant used inside that pr and see if you can add a local fix there
@iMac7 check any pill variant used inside that pr and see if you can add a local fix there Just uncommenting this seems to fix things, are you suggesting I leave the comment as it is and apply local fixes on the pill buttons?
Code Climate has analyzed commit 87e2b631 and detected 0 issues on this pull request.
View more on Code Climate.
Quality Gate passed
Issues
0 New issues
Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code
Oh yes. I commented that line out It was causing wierd behviour on code Checker pill variant buttons
So whatever fix is. Please check that buttons over there stay centered Pay attention to button that have icon as well
https://canary.kodadot.xyz/code-checker
Oh yes. I commented that line out It was causing wierd behviour on code Checker pill variant buttons
So whatever fix is. Please check that buttons over there stay centered Pay attention to button that have icon as well
https://canary.kodadot.xyz/code-checker
it was happening on the pill variants, any style that overrides a similar style in NeoButton.scss
is not applied