Translation hi.json issue #9253

[TouchstoneTheDev]

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

• [ ] Bugfix
• [x] Feature
• [ ] Refactoring

Context

• [x] Closes #9253
• [ ] Requires deployment <snek/rubick/worker>

Before submitting pull request, please make sure:

• [ ] My contribution builds clean without any errors or warnings
• [ ] I've merged recent default branch -- main and I've no conflicts
• [ ] I've tried to respect high code quality standards
• [ ] I've didn't break any original functionality

Optional

• [ ] I've tested it at </ksm/collection>
• [ ] I've tested PR on mobile
• [ ] I've written unit tests 🧪
• [ ] I've found edge cases

Did your issue had any of the "$" label on it?

• [ ] Fill up your DOT address: Payout

Community participation

• [ ] Are you at KodaDot Ecosystem Telegram?

Screenshot 📸

• [x] My fix has changed something on UI; a screenshot is best to understand changes for others.

[kodabot]

SUCCESS @TouchstoneTheDev PR for issue #9253 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

[netlify[bot]]

✅ Deploy Preview for koda-canary ready!

Name	Link
🔨 Latest commit	9353e7c0bf349e43a6ddbbfe23bc9a69160c4cc4
🔍 Latest deploy log	https://app.netlify.com/sites/koda-canary/deploys/65d08182ebc186000830c4a0
😎 Deploy Preview	https://deploy-preview-9271--koda-canary.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[TouchstoneTheDev]

When i run pnpm run locales:check it formats all files ?! when i am trying to look for missing keys also it's just formatting other translations, so it'll be chaos at PR submission !? @roiLeo

[roiLeo]

When i run pnpm run locales:check it formats all files ?! when i am trying to look for missing keys also it's just formatting other translations, so it'll be chaos at PR submission !? @roiLeo

Like I said:

main goal is to open new PR with missing key in en.json file

So first add en translation, then add hi

[TouchstoneTheDev]

what do you mean by en translations ? i didn't cahnged anything in en.json !

[roiLeo]

what do you mean by by en translations ? i didn't cahnged anything in en.json !

We need to add missing keys in en.json file as the whole app is not fully translated. And then you will need to add these missing keys to hi.json file

[TouchstoneTheDev]

what do you mean by by en translations ? i didn't cahnged anything in en.json !

We need to add missing keys in en.json file as the whole app is not fully translated. And then you will need to add these missing keys to hi.json file

where to find the original or missing keys ?

[roiLeo]

where to find the original or missing keys ?

look around in app, each text that is not wrapped in $t(...) need to be in en.json file

For example see https://github.com/kodadot/nft-gallery/pull/9271#pullrequestreview-1861546317 it's missing these keys

[TouchstoneTheDev]

Isn't there any version history where you have all the keys as expected :)

[roiLeo]

Isn't there any version history where you have all the keys as expected :)

Nope, that's why we need to add them

[TouchstoneTheDev]

TH how they went missing XO

Nope, that's why we need to add them

Okie, we'll do it

missing keys in en.json should be new issue.

[codeclimate[bot]]

Code Climate has analyzed commit 9353e7c0 and detected 0 issues on this pull request.

View more on Code Climate.

[sonarqubecloud[bot]]

Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

[yangwao]

@TouchstoneTheDev looks like stale PR to me since 17/2.

Please reopen if you plan to finish it. It's eligible for bounty.