🔧 fix & introduce burn collection on snek

[roiLeo]

PR type

• [x] Bugfix

What's new?

• [x] PR closes #3423
• [x] fix graphql query

Before submitting Pull Request, please make sure:

• [x] My contribution builds clean without any errors or warnings
• [x] I've merged recent default branch -- main and I've no conflicts
• [x] I've tried to respect high code quality standards
• [x] I've didn't break any original functionality
• [x] I've posted a screenshot of demonstrated change in this PR

Screenshot

[netlify[bot]]

✅ Deploy Preview for koda-nuxt ready!

Name	Link
🔨 Latest commit	ed2b7aeafc66b5246995c555856ea42d4efd6de8
🔍 Latest deploy log	https://app.netlify.com/sites/koda-nuxt/deploys/6332cfac90bff60008e5e2f4
😎 Deploy Preview	https://deploy-preview-3991--koda-nuxt.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[roiLeo]

Collection is still showing on /create even after success burning

[petersopko]

Collection is still showing on /create even after success burning

@roiLeo not sure about this one, indexer shows me it's burned but I can still visit the link and find visibly unchanged collection, even when indexer shows "burned": true

[roiLeo]

@roiLeo not sure about this one, indexer shows me it's burned but I can still visit the link and find visibly unchanged collection, even when indexer shows "burned": true

What are we talking about? how indexer shows you it's burned? can you share an Id or link or query?

edit: nvm, I find what you were talking about

query MyQuery {
  collectionEntityById(id: "1178647913") {
    id
    issuer
    metadata
    blockNumber
    burned
    createdAt
    currentOwner
    name
    type
    updatedAt
  }
}

I'll update query on CreateNft to hide burned collection

[petersopko]

@roiLeo not sure about this one, indexer shows me it's burned but I can still visit the link and find visibly unchanged collection, even when indexer shows "burned": true

What are we talking about? how indexer shows you it's burned? can you share an Id or link or query?

here's the link for the burned collection: https://deploy-preview-3991--koda-nuxt.netlify.app/snek/collection/756873665 here's link for latest snek: (edit: new latest snek) https://app.gc.subsquid.io/beta/snekk/005/graphql here's the query and result:

[petersopko]

@roiLeo and I can select the collection and try to mint NFT in it, it results in:

[roiLeo]

Collection is still showing on /create even after success burning

Didn't knew there was a burned attribute for snek/bsx CollectionEntity, it should be fix now

[petersopko]

one more thing the screen where you can see this collection doesn't look changed ( you can still try to burn it), don't we want to differentiate this in similar way to burned NFTs? (adding 🔥somewhere?) https://deploy-preview-3991--koda-nuxt.netlify.app/snek/collection/756873665

[roiLeo]

one more thing the screen where you can see this collection doesn't look changed ( you can still try to burn it), don't we want to differentiate this in similar way to burned NFTs? (adding 🔥somewhere?)

I don't really have an idea how to show it's burned, except maybe to add 🔥 before the name but it could be confused with collection with 🔥 in name. Additional note: Should we change to Fire icon instead of a bin?

I would like to iterate this feature in #3206 as I think I understand the process to burn a full collection. (swip offers -> burn nfts -> burn collection)

Feel free to share burned collection & burned nfts link that could help

[petersopko]

I don't really have an idea how to show it's burned, except maybe to add 🔥 before the name but it could be confused with collection with 🔥 in name. Additional note: Should we change to Fire icon instead of a bin?

here's how it's done at NFTs level: https://beta.kodadot.xyz/rmrk/gallery/14404871-08bfa1909b24cfe94d-%20%F0%9F%8D%AD-ME-0000000000000006

I would like to iterate this feature in #3206 as I think I understand the process to burn a full collection. (swip offers -> burn nfts -> burn collection)

sure 🚀

[petersopko]

@roiLeo any updates on this? :)

[roiLeo]

@roiLeo any updates on this? :)

This can be merged, next step will be #3206

Changes to show Burned collection are breaking RMRK chain since it share the same query with snek

Cannot query field "burned" on type "CollectionEntity".

[codeclimate[bot]]

Code Climate has analyzed commit ed2b7aea and detected 0 issues on this pull request.

View more on Code Climate.