nft-gallery icon indicating copy to clipboard operation
nft-gallery copied to clipboard

Update 🇷🇺Russian translation in KodaDot

Open jakartinho opened this issue 2 years ago • 7 comments

Thank you for your contribution to the KodaDot NFT gallery. 👇 _ Let's make a quick check before the contribution.

PR type

  • [ ] Bugfix
  • [x] Feature
  • [ ] Refactoring

What's new?

  • [ ] PR closes #<issue_number>
  • [ ] Requires deployment <rubick/magick_issue>
  • [ ] <brief_description_of_what_I've_added>

Before submitting Pull Request, please make sure:

  • [ ] My contribution builds clean without any errors or warnings
  • [ ] I've merged recent default branch -- main and I've no conflicts
  • [ ] I've tried to respect high code quality standards
  • [ ] I've didn't break any original functionality
  • [ ] I've posted a screenshot of demonstrated change in this PR

Optional

  • [ ] I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • [ ] I've tested PR on mobile and everything seems works
  • [ ] I found edge cases
  • [ ] I've written some unit tests 🧪

Had issue bounty label?

  • [ ] Fill up your KSM address: Payout

Community participation

Screenshot

  • [ ] My fix has changed something on UI; a screenshot is best to understand changes for others.

jakartinho avatar Sep 13 '22 20:09 jakartinho

Deploy Preview for koda-nuxt ready!

Name Link
Latest commit 781ab12871eaf30401d1fdf7f7c7a6ed29eff22d
Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/6332cdb4ccadab0008cbfa68
Deploy Preview https://deploy-preview-3953--koda-nuxt.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Sep 13 '22 20:09 netlify[bot]

i assume we run into the same issues here, that we faced in my translation @petersopko

spacesmutje avatar Sep 21 '22 20:09 spacesmutje

we need to find some way to encode cyrillic characters

You may need an additional loader to handle the result of these loaders.
  SyntaxError: Unexpected string in JSON at position 34455 while parsing '{
  "translation": "Русский",

kkukelka avatar Sep 22 '22 04:09 kkukelka

we need to find some way to encode cyrillic characters

just invalid json with curly brackets misplaced

petersopko avatar Sep 22 '22 11:09 petersopko

@jakartinho do you know anybody else who speaks the language and can also verify some of this? 😄

petersopko avatar Sep 23 '22 06:09 petersopko

@jakartinho do you know anybody else who speaks the language and can also verify some of this? 😄

I'll try to find it :)

jakartinho avatar Sep 23 '22 07:09 jakartinho

has

I found a man, he will check today and report back here.

jakartinho avatar Sep 26 '22 08:09 jakartinho

Greetings! Jakartinho asked me to check for grammatical and syntactical mistakes. I declare that after checking the translation, no mistakes were found. It is a high-quality translation.

Black322 avatar Sep 26 '22 12:09 Black322

Greetings! Jakartinho asked me to check for grammatical and syntactical mistakes. I declare that after checking the translation, no mistakes were found. It is a high-quality translation.

Thanks, buddy!

@petersopko Done, the work has been checked!

jakartinho avatar Sep 26 '22 12:09 jakartinho

Code Climate has analyzed commit 781ab128 and detected 0 issues on this pull request.

View more on Code Climate.

codeclimate[bot] avatar Sep 27 '22 10:09 codeclimate[bot]

pay 100 usd

petersopko avatar Sep 27 '22 10:09 petersopko

pay 100 usd

looks like this payment didn't happen? gonna try again

petersopko avatar Oct 02 '22 06:10 petersopko

pay 100 usd

petersopko avatar Oct 02 '22 06:10 petersopko

not sure what kind of problem is here, @yangwao pls check

petersopko avatar Oct 02 '22 06:10 petersopko

pay 100 usd

looks like this payment didn't happen? gonna try again

Hi, maybe I filled something wrong. Here's my wallet, last time someone added it as well.

EaCNjunMHRRPZfzGCX66dbZcwrZsRZBBVu4YzBU58t1TwwG

jakartinho avatar Oct 02 '22 06:10 jakartinho

pay 100 usd

yangwao avatar Oct 07 '22 08:10 yangwao

😍 Perfect, I’ve sent the payout 💵 $100 @ 43.36 USD/KSM ~ 2.306 $KSM 🧗 EaCNjunMHRRPZfzGCX66dbZcwrZsRZBBVu4YzBU58t1TwwG 🔗 0x0462209a8cbd3be3817fa40ae956f9956e0a89b78b522635f46814a70aa6affb

🪅 Let’s grab another issue and get rewarded! 🪄 github.com/kodadot/nft-gallery/issues

yangwao avatar Oct 07 '22 08:10 yangwao

autocode had some outage, those webhooks doesn't pick up tho later on so, not perfect, not terrible

yangwao avatar Oct 07 '22 08:10 yangwao