nft-gallery
nft-gallery copied to clipboard
kodadot
Handle expired offers acceptation
Currently on our front end, we leave space for confusion when it comes to expired offers. On image below, there is one of my NFTs after clicking on Action button, accept offer.
Proposed solution:
Let user click on the button and show red text above the table, saying Selected offer is expired and can no longer be accepted. Inspiration can be found in the way errors are handled at Create NFTs /bsx/create Maybe @roiLeo can chip in on how to handle this properly, but iirc you don't like disabling buttons + tooltips 😆.
Don't forget to test: Every place which has option of accepting offers.
ASSIGNED - @kkukelka 🔒 LOCKED -> Saturday, August 20th 2022, 23:50:58 UTC -> 36 hours
Should we keep showing expired offer? I noticed that on OpenSea they are no longer displayed
hmm, maybe not everywhere? There are two related issues:
- https://github.com/kodadot/nft-gallery/issues/3401
- https://github.com/kodadot/nft-gallery/issues/3583
From the context, I think we want to keep them for user to withdraw, but maybe we don't want to show them at item detail? wdyt @yangwao
Oh, I recall, when an offer is made the balance is locked until the user withdraw even when expire
Should we keep showing expired offer?
we could default show active offers.
maybe we don't want to show them at item detail?
why?
maybe we don't want to show them at item detail?
why?
It's like showing "out of stock" product on a marketplace this can be confusing for the user.
But it would be nice to have a tab in my profile where I could manage all my expired offers (#3401?)
I'll unassign myself until there is a consensus reached on what's the best approach here
It's like showing "out of stock" product on a marketplace this can be confusing for the user.
But it would be nice to have a tab in my profile where I could manage all my expired offers (#3401?)
maybe we want to show activity on the given item regardless and that was @yangwao's point? Created (even if expired) offer signals some demand for the item. @yangwao wdyt, maybe just disable the "Accept" green bill button when offer is expired?
Current implementation is still resulting in user being able to click the accept button, sign transaction and get response as seen on the screenshot.
This was left on read for way too long, let's resolve this in the following way:
- We are leaving expired offers to show, they are a good sign of activity around NFT
- We should handle the button in a better way, I'd suggest disabled
Acceptwith tooltip informing about the expiration of offer (please @roiLeo, take a look and let us know if there's more elegant way🧙🏻♂️)
We are leaving expired offers to show, they are a good sign of activity around NFT
Aight, still don't agree with it but let's keep them
I'd suggest disabled
Acceptwith tooltip informing about the expiration of offer
Sounds good to me, can we sort offers by expiration Date too?
Sounds good to me, can we sort offers by expiration Date too?
it seems to be working
