nft-gallery
nft-gallery copied to clipboard
Refactor: landing page
Refactor components to use vue composition API. To make it easier for review and test, I will make multiple PR based on this list:
trying to refactor from the deepest/low-level component, in summary, carousel components are something like this:
carousel
├── card
│ └── media
│ └── identity
│ └── identity-popover
- [ ] curated list
- [x] #3772
- [ ] #3776
- [ ] latest sales, popular collections, and newest list (move component from /rmrk/)
- [x] #3773
- [x] #3774
- [x] #3865
- [ ] #3928
- [ ] #3927
- [ ] #3775
- [x] identity
- [x] https://github.com/kodadot/nft-gallery/issues/3747
- [x] https://github.com/kodadot/nft-gallery/issues/3749
- [x] https://github.com/kodadot/nft-gallery/issues/3760
- [x] media
- [x] https://github.com/kodadot/nft-gallery/pull/3718
- [x] https://github.com/kodadot/nft-gallery/issues/3750
- [ ] tbd...
to avoid losing so much context when reviewing the code, create a separate PR for refactoring to vue compose API. context: https://github.com/kodadot/nft-gallery/pull/3718#pullrequestreview-1072558888
ASSIGNED - @preschian 🔒 LOCKED -> Saturday, August 13th 2022, 01:57:14 UTC -> 36 hours
ASSIGNMENT EXPIRED - @preschian has been unassigned.
ASSIGNMENT EXPIRED - @preschian has been unassigned.
@preschian you need to link the issues in PR if you want to keep the assignment going past the allocated time :)
@preschian or should the PR solve this one only partially? perhaps we can extract the part you've done to standalone issue if that's the case?
@preschian or should the PR solve this one only partially? perhaps we can extract the part you've done to standalone issue if that's the case?
oohh I think this is better. Yaps, this is only partial, next parts I will open a new standalone issue and link to this issue 👍
lol why it closed even not linked as pr closes
🤔
thanks for reopening 🙌
lol why it closed even not linked as
pr closes

linked issue in pr will close
I close this, some components left are tracked here https://github.com/kodadot/nft-gallery/issues/3950