nft-gallery icon indicating copy to clipboard operation
nft-gallery copied to clipboard

Refactor: landing page

Open preschian opened this issue 2 years ago • 7 comments

Refactor components to use vue composition API. To make it easier for review and test, I will make multiple PR based on this list:

trying to refactor from the deepest/low-level component, in summary, carousel components are something like this:

carousel
├── card
│   └── media
│   └── identity
│       └── identity-popover
  • [ ] curated list
    • [x] #3772
    • [ ] #3776
  • [ ] latest sales, popular collections, and newest list (move component from /rmrk/)
    • [x] #3773
    • [x] #3774
    • [x] #3865
    • [ ] #3928
    • [ ] #3927
    • [ ] #3775
  • [x] identity
    • [x] https://github.com/kodadot/nft-gallery/issues/3747
    • [x] https://github.com/kodadot/nft-gallery/issues/3749
    • [x] https://github.com/kodadot/nft-gallery/issues/3760
  • [x] media
    • [x] https://github.com/kodadot/nft-gallery/pull/3718
    • [x] https://github.com/kodadot/nft-gallery/issues/3750
  • [ ] tbd...

to avoid losing so much context when reviewing the code, create a separate PR for refactoring to vue compose API. context: https://github.com/kodadot/nft-gallery/pull/3718#pullrequestreview-1072558888

preschian avatar Aug 11 '22 13:08 preschian

ASSIGNED - @preschian 🔒 LOCKED -> Saturday, August 13th 2022, 01:57:14 UTC -> 36 hours

kodabot avatar Aug 11 '22 13:08 kodabot

ASSIGNMENT EXPIRED - @preschian has been unassigned.

kodabot avatar Aug 13 '22 01:08 kodabot

ASSIGNMENT EXPIRED - @preschian has been unassigned.

@preschian you need to link the issues in PR if you want to keep the assignment going past the allocated time :)

petersopko avatar Aug 13 '22 07:08 petersopko

@preschian or should the PR solve this one only partially? perhaps we can extract the part you've done to standalone issue if that's the case?

petersopko avatar Aug 13 '22 07:08 petersopko

@preschian or should the PR solve this one only partially? perhaps we can extract the part you've done to standalone issue if that's the case?

oohh I think this is better. Yaps, this is only partial, next parts I will open a new standalone issue and link to this issue 👍

preschian avatar Aug 13 '22 07:08 preschian

lol why it closed even not linked as pr closes 🤔 thanks for reopening 🙌

yangwao avatar Aug 18 '22 09:08 yangwao

lol why it closed even not linked as pr closes

Capture d’écran 2022-08-18 à 11 35 14 AM

linked issue in pr will close

roiLeo avatar Aug 18 '22 09:08 roiLeo

I close this, some components left are tracked here https://github.com/kodadot/nft-gallery/issues/3950

preschian avatar Oct 06 '22 09:10 preschian