nft-gallery icon indicating copy to clipboard operation
nft-gallery copied to clipboard

Published 20 hours ago • verified publisher icon kodadot

Issue re: Unlist the nft, after it was sent as a gift

Open jrafaelangarita opened this issue 2 years ago • 3 comments

What happened?

I sent an nft as a gift, to check that it was fixed and when entering the other account (n2), the nft is still listed (action performed in the original account or n1)

Please reproduce in steps

list a nft, send it like gift, check on the receive adress, that is still listed

Expected Behavior

being a gift, it should not save the previous action, and should unlist the nft, otherwise, it may be bought and the owner does not notice

What browsers are you seeing the problem on?

Chrome

At which address did you encounter bug?

beta.kodadot.xyz

Are you logged in?

Yes

Which wallet you are using?

Talisman

Screenshots

Screenshot_98 Screenshot_99

Relevant log output

No response

Payment link for reward

https://kodadot.xyz/transfer?target=Hy8UnZSNvchEzKLBZ6X6qXq6xc8gVNGyo8ALuuNUXeTiD6K&usdamount=10&donation=true

Code of Conduct

  • [X] I agree to follow this project's Code of Conduct

jrafaelangarita avatar Aug 05 '22 17:08 jrafaelangarita

@petersopko 👀

yangwao avatar Aug 16 '22 11:08 yangwao

tested this, still a problem, I've followed up in https://github.com/kodadot/snek/issues/56 since this is most likely going to get solved at indexer level

petersopko avatar Aug 16 '22 15:08 petersopko

This should be implemeted by either:

  • [ ] in Basilisk Node as extension of the runtime pallet
  • [ ] in KodaDot NFT gallery that should perform batchAll[unlist, transfer]

Originally posted by @vikiival in https://github.com/kodadot/snek/issues/56#issuecomment-1255604590

vikiival avatar Sep 22 '22 22:09 vikiival

Can't this be fixed with kodadot/snek#99 since we do the same for rmrk chain?

roiLeo avatar Oct 25 '22 15:10 roiLeo

Can't this be fixed with https://github.com/kodadot/snek/pull/99 since we do the same for rmrk chain?

Unfortunately no. The Basilisk works way differently than "RMRK", If we unlist the token on the snek's side,the NFT is still available on-chain to buy :)

So the only possible options are two mentioned above

vikiival avatar Oct 26 '22 08:10 vikiival

@jrafaelangarita hey thanks for reporting; it was "fixed" you can try it now

sending bounty for reporting it!

pay 30 USD

yangwao avatar Jan 01 '23 20:01 yangwao

😍 Perfect, I’ve sent the payout 💵 $30 @ 22.29 USD/KSM ~ 1.346 $KSM 🧗 Hy8UnZSNvchEzKLBZ6X6qXq6xc8gVNGyo8ALuuNUXeTiD6K 🔗 0xb4728427053fd947a79c4d94b170deb3756ed9164e7385cf5c5d62bfd510d53e

🪅 Let’s grab another issue and get rewarded! 🪄 github.com/kodadot/nft-gallery/issues

yangwao avatar Jan 01 '23 20:01 yangwao