nft-gallery icon indicating copy to clipboard operation
nft-gallery copied to clipboard

WIP: Add Rococo Basilisk explorer

Open Jarsen136 opened this issue 2 years ago β€’ 3 comments

Thank you for your contribution to the KodaDot NFT gallery. πŸ‘‡ _ Let's make a quick check before the contribution.

PR type

  • [ ] Bugfix
  • [x] Feature
  • [ ] Refactoring

What's new?

  • [x] PR closes #3655
  • [ ] Requires deployment <rubick/magick_issue>
  • [ ] <brief_description_of_what_I've_added>

Before submitting Pull Request, please make sure:

  • [x] My contribution builds clean without any errors or warnings
  • [x] I've merged recent default branch -- main and I've no conflicts
  • [x] I've tried to respect high code quality standards
  • [x] I've didn't break any original functionality
  • [ ] I've posted a screenshot of demonstrated change in this PR

Optional

  • [ ] I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • [ ] I've tested PR on mobile and everything seems works
  • [ ] I found edge cases
  • [ ] I've written some unit tests πŸ§ͺ

Had issue bounty label?

  • [x] Fill up your KSM address: Payout

Community participation

Screenshot

  • [ ] My fix has changed something on UI; a screenshot is best to understand changes for others.

Jarsen136 avatar Aug 03 '22 15:08 Jarsen136

SUCCESS @Jarsen136 PR for issue #3655 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

kodabot avatar Aug 03 '22 15:08 kodabot

Deploy Preview for koda-nuxt ready!

Name Link
Latest commit 8fef7a69a78f8800759ab1c5201787717d53ccb2
Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/630f26917bebf900088c7eef
Deploy Preview https://deploy-preview-3661--koda-nuxt.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Aug 03 '22 15:08 netlify[bot]

This PR is blocked. related to https://github.com/kodadot/nft-gallery/issues/3671

Jarsen136 avatar Aug 04 '22 13:08 Jarsen136

Made transactions https://github.com/kodadot/nft-gallery/pull/3784#issuecomment-1230212345

https://calamar.play.hydration.cloud/rococo%20basilisk/extrinsic/0000715279-000002-98663

  • #3784 is merged, means we can fix this one :)

yangwao avatar Aug 29 '22 12:08 yangwao

hmm, still can't see the explorer at /transfers, we've hidden it here so perhaps some things need to be tweaked?

  • https://github.com/kodadot/nft-gallery/pull/3406

petersopko avatar Aug 30 '22 11:08 petersopko

hmm, still can't see the explorer at /transfers, we've hidden it here so perhaps some things need to be tweaked?

Hey, I'm not sure what you mean. Even though I'm at RMRK, I still could not see any explorer at /transfers.

image

Oh, I found it

image

Jarsen136 avatar Aug 30 '22 13:08 Jarsen136

Hey, I'm not sure what you mean. Even though I'm at RMRK, I still could not see any explorer at /transfers.

if you punch in address at rmrk, there's link generated to the profile at subscan image

petersopko avatar Aug 30 '22 13:08 petersopko

Hey, I'm not sure what you mean. Even though I'm at RMRK, I still could not see any explorer at /transfers.

if you punch in address at rmrk, there's link generated to the profile at subscan

βœ… Done

image

Jarsen136 avatar Aug 30 '22 13:08 Jarsen136

Code Climate has analyzed commit 8fef7a69 and detected 0 issues on this pull request.

View more on Code Climate.

codeclimate[bot] avatar Aug 31 '22 09:08 codeclimate[bot]

nice, wfm :)

petersopko avatar Aug 31 '22 10:08 petersopko

@kkukelka can review the code now and we have explorer back :)

petersopko avatar Aug 31 '22 10:08 petersopko

pay 100

kkukelka avatar Sep 01 '22 04:09 kkukelka

😍 Perfect, I’ve sent the payout πŸ’΅ $100 @ 46.63 USD/KSM ~ 2.145 $KSM πŸ§— Caiv9TbPz68q5dC8EcHu5xKYPRnremimGzqmEejDFNpWWLG πŸ”— 0x897bccb0fb9365894205be9b45cfa9ffda803b80161f20598cdf12e02a9c0e50

πŸͺ… Let’s grab another issue and get rewarded! πŸͺ„ github.com/kodadot/nft-gallery/issues

yangwao avatar Sep 01 '22 04:09 yangwao

just 1 question: whats with the # as return value in some cases?

It would not happen because the element would only render when it has block explorer.

v-if="$route.query.target && hasBlockExplorer"

Jarsen136 avatar Sep 01 '22 11:09 Jarsen136