nft-gallery icon indicating copy to clipboard operation
nft-gallery copied to clipboard

Add iqr/h-spread and box plot chart

Open preschian opened this issue 2 years ago β€’ 10 comments

Thank you for your contribution to the KodaDot NFT gallery. πŸ‘‡ _ Let's make a quick check before the contribution.

PR type

  • [ ] Bugfix
  • [x] Feature
  • [ ] Refactoring

What's new?

  • [x] PR closes #1483

Before submitting Pull Request, please make sure:

  • [x] My contribution builds clean without any errors or warnings
  • [x] I've merged the recent default branch -- main and I've no conflicts
  • [x] I've tried to respect high code quality standards
  • [x] I've didn't break any original functionality
  • [x] I've posted a screenshot of demonstrated change in this PR

Optional

  • [x] I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • [x] I've tested PR on mobile and everything seems works
  • [ ] I found edge cases
  • [ ] I've written some unit tests πŸ§ͺ

Had issue bounty label?

  • [x] Fill up your KSM address: Payout

Community participation

Screenshot

  • [x] My fix has changed something on UI; a screenshot is best to understand changes for others.

URL: https://deploy-preview-3585--koda-nuxt.netlify.app/rmrk/collection/2644199cf3652aaa78-KK01?tab=chart Screen Shot 2022-07-27 at 17 47 40

preschian avatar Jul 27 '22 10:07 preschian

SUCCESS @preschian PR for issue #1483 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

kodabot avatar Jul 27 '22 10:07 kodabot

Deploy Preview for koda-nuxt ready!

Name Link
Latest commit c1976620c08b1c5446fed4d3c8b4c5b078a6db52
Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/637eeedd6afa7c0008ac8651
Deploy Preview https://deploy-preview-3585--koda-nuxt.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Jul 27 '22 10:07 netlify[bot]

~move back to draft PR~ ~still checking why the tooltip only works on localhost~

solved, ready to review Screen Shot 2022-07-27 at 18 48 47

preschian avatar Jul 27 '22 11:07 preschian

cc @yangwao for feedback

preschian avatar Aug 01 '22 02:08 preschian

move to draft PR. will revisit again when https://github.com/kodadot/nft-gallery/pull/3651 merged

preschian avatar Aug 04 '22 11:08 preschian

Sir, any updates with this ?

vikiival avatar Sep 19 '22 17:09 vikiival

Also what kind of data do you need ?

we can do that on rubick instead of making fancy magic on frontend

vikiival avatar Sep 19 '22 17:09 vikiival

Also what kind of data do you need ?

we can do that on rubick instead of making fancy magic on frontend

I almost forgot these changes. let me resolve the conflicts first

preschian avatar Sep 21 '22 05:09 preschian

Also what kind of data do you need ?

we can do that on rubick instead of making fancy magic on frontend

regarding data on Rubick, what if we start by revisiting the line chart? currently, the line chart on bsx and rmrk use different data sources/API

from the latest discussion, there are still areas of improvement regarding the line chart also https://github.com/kodadot/nft-gallery/issues/3646#issuecomment-1207985634

preschian avatar Sep 21 '22 05:09 preschian

@preschian @vikiival not sure what the status is here, are we going to do this on rubick or is this ready for review? It seems to me that we have at least some functioning version here πŸ˜„ image

petersopko avatar Sep 26 '22 07:09 petersopko

@preschian @vikiival not sure what the status is here, are we going to do this on rubick or is this ready for review? It seems to me that we have at least some functioning version here πŸ˜„

from me is ready to review. but I need @vikiival approval is it ok to go or not

we can do that on rubick instead of making fancy magic on frontend

either way, later on, I will open an issue regarding the @vikiival concern. because currently chart on collection only works on rmrk. need to figure it out, maybe we can reuse data from the History tab to show the chart or need additional data

preschian avatar Sep 26 '22 13:09 preschian

from me is ready to review. but I need @vikiival approval is it ok to go or not

okay, lgtm

petersopko avatar Sep 27 '22 09:09 petersopko

@vikiival I tried to explain here https://github.com/kodadot/nft-gallery/issues/4052

preschian avatar Sep 29 '22 05:09 preschian

can we move this forward and solve the multichain support elsewhere? :)

petersopko avatar Sep 30 '22 05:09 petersopko

Code Climate has analyzed commit c1976620 and detected 0 issues on this pull request.

View more on Code Climate.

codeclimate[bot] avatar Nov 24 '22 04:11 codeclimate[bot]

can we move this forward?

cc @yangwao @vikiival

preschian avatar Nov 24 '22 04:11 preschian

YOLO v2

vikiival avatar Nov 24 '22 11:11 vikiival

pay 100 usd

yangwao avatar Jan 08 '23 13:01 yangwao

😍 Perfect, I’ve sent the payout πŸ’΅ $100 @ 24.32 USD/KSM ~ 4.112 $KSM πŸ§— DY4SQF2iD456tH89aQtz5wv1EV3BbSW8wKKuMcwbmXaj1pM πŸ”— 0xb5fde6abf8fb1e7baf9f9f4c3aeb6bc332699dd20d822e80d6b645181055e89c

πŸͺ… Let’s grab another issue and get rewarded! πŸͺ„ github.com/kodadot/nft-gallery/issues

yangwao avatar Jan 08 '23 13:01 yangwao