nft-gallery
nft-gallery copied to clipboard
Add iqr/h-spread and box plot chart
Thank you for your contribution to the KodaDot NFT gallery. π _ Let's make a quick check before the contribution.
PR type
- [ ] Bugfix
- [x] Feature
- [ ] Refactoring
What's new?
- [x] PR closes #1483
Before submitting Pull Request, please make sure:
- [x] My contribution builds clean without any errors or warnings
- [x] I've merged the recent default branch -- main and I've no conflicts
- [x] I've tried to respect high code quality standards
- [x] I've didn't break any original functionality
- [x] I've posted a screenshot of demonstrated change in this PR
Optional
- [x] I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
- [x] I've tested PR on mobile and everything seems works
- [ ] I found edge cases
- [ ] I've written some unit tests π§ͺ
Had issue bounty label?
- [x] Fill up your KSM address: Payout
Community participation
Screenshot
- [x] My fix has changed something on UI; a screenshot is best to understand changes for others.
URL: https://deploy-preview-3585--koda-nuxt.netlify.app/rmrk/collection/2644199cf3652aaa78-KK01?tab=chart
SUCCESS @preschian PR for issue #1483 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!
Deploy Preview for koda-nuxt ready!
Name | Link |
---|---|
Latest commit | c1976620c08b1c5446fed4d3c8b4c5b078a6db52 |
Latest deploy log | https://app.netlify.com/sites/koda-nuxt/deploys/637eeedd6afa7c0008ac8651 |
Deploy Preview | https://deploy-preview-3585--koda-nuxt.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
~move back to draft PR~ ~still checking why the tooltip only works on localhost~
solved, ready to review
cc @yangwao for feedback
move to draft PR. will revisit again when https://github.com/kodadot/nft-gallery/pull/3651 merged
Sir, any updates with this ?
Also what kind of data do you need ?
we can do that on rubick instead of making fancy magic on frontend
Also what kind of data do you need ?
we can do that on rubick instead of making fancy magic on frontend
I almost forgot these changes. let me resolve the conflicts first
Also what kind of data do you need ?
we can do that on rubick instead of making fancy magic on frontend
regarding data on Rubick, what if we start by revisiting the line chart? currently, the line chart on bsx and rmrk use different data sources/API
from the latest discussion, there are still areas of improvement regarding the line chart also https://github.com/kodadot/nft-gallery/issues/3646#issuecomment-1207985634
@preschian @vikiival not sure what the status is here, are we going to do this on rubick or is this ready for review? It seems to me that we have at least some functioning version here π
@preschian @vikiival not sure what the status is here, are we going to do this on rubick or is this ready for review? It seems to me that we have at least some functioning version here π
from me is ready to review. but I need @vikiival approval is it ok to go or not
we can do that on rubick instead of making fancy magic on frontend
either way, later on, I will open an issue regarding the @vikiival concern. because currently chart on collection only works on rmrk
. need to figure it out, maybe we can reuse data from the History
tab to show the chart or need additional data
from me is ready to review. but I need @vikiival approval is it ok to go or not
okay, lgtm
@vikiival I tried to explain here https://github.com/kodadot/nft-gallery/issues/4052
can we move this forward and solve the multichain support elsewhere? :)
Code Climate has analyzed commit c1976620 and detected 0 issues on this pull request.
View more on Code Climate.
can we move this forward?
cc @yangwao @vikiival
YOLO v2
pay 100 usd
π Perfect, Iβve sent the payout π΅ $100 @ 24.32 USD/KSM ~ 4.112 $KSM π§ DY4SQF2iD456tH89aQtz5wv1EV3BbSW8wKKuMcwbmXaj1pM π 0xb5fde6abf8fb1e7baf9f9f4c3aeb6bc332699dd20d822e80d6b645181055e89c
πͺ Letβs grab another issue and get rewarded! πͺ github.com/kodadot/nft-gallery/issues