nft-gallery icon indicating copy to clipboard operation
nft-gallery copied to clipboard

Offer Status - Expired?

Open petersopko opened this issue 2 years ago • 11 comments

One thing I've noticed at couple of places is that we don't have status of offer that would say EXPIRED, therefore all of the expired offers are whatever states they are in (expiration doesn't change status of Offer). @vikiival mentioned something like hook which could solve this, I'm opening up and issue and marking as research.

image

Originally posted by @petersopko in https://github.com/kodadot/nft-gallery/issues/3578#issuecomment-1196519693

petersopko avatar Jul 27 '22 09:07 petersopko

yeah I think if we can add an expired status it will be useful for #3401

prachi00 avatar Aug 03 '22 04:08 prachi00

Issue is here. May @KngZhi can pickup https://github.com/kodadot/snek/issues/13

vikiival avatar Aug 03 '22 08:08 vikiival

👋

KngZhi avatar Aug 03 '22 08:08 KngZhi

ISSUE RESEARCHED - issue #3583 is researched. Please wait until issue becomes finalized.

kodabot avatar Aug 03 '22 08:08 kodabot

Okay, I will try it.

KngZhi avatar Aug 03 '22 08:08 KngZhi

ASSIGNED - @petersopko 🔒 LOCKED -> Thursday, August 4th 2022, 20:46:50 UTC -> 36 hours

kodabot avatar Aug 03 '22 08:08 kodabot

ASSIGNMENT OVER - @petersopko has been unassigned.

kodabot avatar Aug 03 '22 08:08 kodabot

just to be @KngZhi sure: This task is focused on the https://github.com/kodadot/snek/issues/13

vikiival avatar Aug 03 '22 08:08 vikiival

Got it.

KngZhi avatar Aug 03 '22 08:08 KngZhi

@petersopko could you share the link of the screenshot, thus I can test?

KngZhi avatar Aug 03 '22 09:08 KngZhi

@petersopko could you share the link of the screenshot, thus I can test?

you can check out the screen shot here:

  • https://beta.kodadot.xyz/bsx/u/bXkVgiXLvvJAmUNni8huN9NZdjaxKGav9fSszhRXFeg6Xuvih?tab=offers&page=1

petersopko avatar Aug 03 '22 09:08 petersopko

closed in favor of https://github.com/kodadot/snek/issues/13

roiLeo avatar Mar 24 '23 11:03 roiLeo