nft-gallery icon indicating copy to clipboard operation
nft-gallery copied to clipboard

Master Offers component v2

Open yangwao opened this issue 2 years ago • 12 comments

Great idea; I guess we can make a functional component with an address as param and input and merge these three current ones.

When the logged-in user visits /bsx/offers it lands on its own address stats by default, i.e. in my case /bsx/offers?u=bXgvP2cQzEnPvuPQHRghz9dUYovqzyPhXBRXbNwVCef7nsmqb where default would be incoming offers

There should be two filters where you can choose

  • F1
    • created offers by particular address
    • incoming offers by particular address
  • F2
    • Active
    • Accepted
    • Withdrawn

When the non-logged user opens it, they should see a global table like at https://beta.kodadot.xyz/bsx/stats, so F1 should be disabled.

The goal would be for anyone/user can see per address offers

  • created
  • incoming
  • global

We can put it under the Stats dropdown in the navbar with the name Offers.

Later it becomes the replacement for current stats

Work can start once the issues below are completed.

  • #3450
  • #3203
  • #2801

Originally posted by @yangwao in https://github.com/kodadot/nft-gallery/issues/3462#issuecomment-1187044108

yangwao avatar Jul 18 '22 12:07 yangwao

👋

prachi00 avatar Jul 19 '22 05:07 prachi00

ISSUE BLOCKED - issue #3463 is blocked. Please wait until issue is unblocked.

kodabot avatar Jul 19 '22 05:07 kodabot

I can work on this once unblocked 😊

prachi00 avatar Jul 19 '22 19:07 prachi00

Adding comment here to follow from

  • #3477

It would be nice to have some sort of option (maybe toggle) to show only active offers, since those are the ones which will be (I assume) most interesting to the user most of the time

petersopko avatar Jul 20 '22 15:07 petersopko

Adding comment here to follow from

It would be nice to have some sort of option (maybe toggle) to show only active offers, since those are the ones which will be (I assume) most interesting to the user most of the time

I guess we can add filters like the history table?

prachi00 avatar Jul 20 '22 19:07 prachi00

Adding comment here to follow from

It would be nice to have some sort of option (maybe toggle) to show only active offers, since those are the ones which will be (I assume) most interesting to the user most of the time

I guess we can add filters like the history table?

yup, I guess that would be the best way to go, something like this: image

petersopko avatar Jul 21 '22 08:07 petersopko

@yangwao how are we keeping the UI for this one? do we have any reference? like are we giving an option here like Transfer, a dedicated page to check offer for any address?

Screen Shot 2022-07-22 at 4 24 40 PM

prachi00 avatar Jul 22 '22 23:07 prachi00

@yangwao how are we keeping the UI for this one? do we have any reference? like are we giving an option here like Transfer, a dedicated page to check offer for any address?

Screen Shot 2022-07-22 at 4 24 40 PM

@yangwao need a little help with the ui ux part of this oneee

prachi00 avatar Jul 29 '22 01:07 prachi00

a dedicated page to check offer for any address?

yes. check original issue, I've just updated it :)

yangwao avatar Aug 03 '22 10:08 yangwao

Okay I'll start working on this one

prachi00 avatar Aug 03 '22 15:08 prachi00

@yangwao so when you say F1 filter, do you mean two tabs? where one tab shows created offers by particular address TABLE and other shows incoming offers by particular address TABLE and at the top we can have a text input field where we can input the particular address?

prachi00 avatar Aug 04 '22 04:08 prachi00

ASSIGNED - @prachi00 🔒 LOCKED -> Monday, August 8th 2022, 05:13:56 UTC -> 72 hours

kodabot avatar Aug 05 '22 05:08 kodabot