nft-gallery icon indicating copy to clipboard operation
nft-gallery copied to clipboard

πŸ’… fresh UI update

Open roiLeo opened this issue 2 years ago β€’ 13 comments

🚧 WIP 🚧

PR type

  • [x] Feature
  • [x] Refactoring

What's new?

  • [x] PR related #2792
  • [x] PR related #1348
  • [x] PR related #153
  • [x] more (s)css changes to come

TODO

  • [x] fix navbar-shrink
  • [x] dark/light mode (wip need review/tests)
  • [ ] new filters ? (design ready)
  • [ ] dev compiled warnings ?

Screenshot

lightMode

Screenshot 2022-06-02 at 15-29-34 KodaDot - Kusama NFT Market Explorer

darkMode

Screenshot 2022-06-02 at 15-30-17 KodaDot - Kusama NFT Market Explorer

roiLeo avatar May 04 '22 16:05 roiLeo

Deploy Preview for koda-nuxt ready!

Name Link
Latest commit aa4180db31fd189e5135875f0c36ed897197b634
Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/62fa12bc2a5302000816ea88
Deploy Preview https://deploy-preview-2947--koda-nuxt.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar May 04 '22 16:05 netlify[bot]

:3 uwu looking forward

vikiival avatar May 05 '22 13:05 vikiival

Ping me when ready for review πŸ”’

vikiival avatar May 06 '22 07:05 vikiival

Ping me when ready for review πŸ”’

Feel free to start reviewing code and design, maybe @XyloDrone can check too

Do I start integrating dark mode on this branch? Same question for the new side filters? (not present in this PR) Capture d’écran 2022-05-10 aΜ€ 2 41 54 PM

roiLeo avatar May 10 '22 14:05 roiLeo

That's lit πŸ”₯

vikiival avatar May 11 '22 10:05 vikiival

hollly, this looks really nice. πŸš€

encountered a small UI issue.

https://user-images.githubusercontent.com/11361147/168646900-08cbf5f7-359d-46e1-a56b-01908b85785e.mov

KngZhi avatar May 16 '22 17:05 KngZhi

maybe let's merge it this / next week ? there will be imo more conflicts

d1816a2

vikiival avatar Jun 15 '22 12:06 vikiival

maybe let's merge it this / next week ? there will be imo more conflicts

Or we can wait for #3134 + I might need more feedback on dark/light mode UI since I didn't test all pages/components, no need to rush

roiLeo avatar Jun 15 '22 12:06 roiLeo

@preschian let's make white background default

yangwao avatar Aug 10 '22 15:08 yangwao

Best to resolve conflicts only and then can proceed with making all white backgrounds

  • https://github.com/kodadot/nft-gallery/issues/3713

yangwao avatar Aug 11 '22 09:08 yangwao

Hey, @JustLuuuu @cryptodamsky let's do click journey thorough whole KodaDot, if you spot something not working lmk; mainly we are looking read-only stuff, if things working okayish :)

Known issues

  • some tables are black, will be fixed in
    • #3713

yangwao avatar Aug 11 '22 13:08 yangwao

Beautiful 😍

image

yangwao avatar Aug 11 '22 13:08 yangwao

got this after burning NFT: image

petersopko avatar Aug 12 '22 09:08 petersopko

when I change the screen to smaller size, I'm capable of achieving this in searchbar on top, not the best look, maybe shorten it back to just "Search..." if the screen is smaller?

image

petersopko avatar Aug 12 '22 10:08 petersopko

Light mode: Create (classic) collection: Collection description is still in a dark mode - is that on purpose? image

Create: Simple/Creative - everything is still in a dark mode image

When you open NFT - price is also in a dark square image

JustLuuuu avatar Aug 12 '22 12:08 JustLuuuu

@JustLuuuu

  • https://github.com/kodadot/nft-gallery/issues/3713

petersopko avatar Aug 12 '22 13:08 petersopko

Here he comes

image

yangwao avatar Aug 12 '22 14:08 yangwao

Can you make me default white πŸ₯ΉπŸ™

yangwao avatar Aug 13 '22 09:08 yangwao

Can you make me default white πŸ₯ΉπŸ™

Not sure what you mean about that, default color-mode is from user preference:

it will automatically detect the color mode based on the system preferences (see prefers-color-mode spec). The value injected will be either 'light' or 'dark'. If no-preference is detected or the browser does not handle color-mode, it will set the fallback value. (light)

roiLeo avatar Aug 13 '22 10:08 roiLeo

Not sure what you mean about that, default color-mode is from user preference:

we will have by default white only in the upcoming design, so when for example, will be white only landing will redirect the user to black explorer; I sense it would not be looking good :/

yangwao avatar Aug 13 '22 13:08 yangwao

Code Climate has analyzed commit aa4180db and detected 0 issues on this pull request.

View more on Code Climate.

codeclimate[bot] avatar Aug 15 '22 09:08 codeclimate[bot]

Let it roll :) We will add a dark version for the new landing page as well πŸ‘€

yangwao avatar Aug 15 '22 10:08 yangwao