nft-gallery
nft-gallery copied to clipboard
🔧 router scrollBehavior
- fix scroll position behavior on route change
- test is on small screen collection detail page (change tabs)
Summary by CodeRabbit
- Refactor
- Updated the router scroll behavior configuration to a new format, maintaining custom scroll logic for route navigation.
- Chores
- Removed the old scroll behavior file to streamline configuration.
Deploy Preview for koda-canary ready!
| Name | Link |
|---|---|
| Latest commit | d3539e7bb1875cfe10e8c328c9fde963187bd299 |
| Latest deploy log | https://app.netlify.com/projects/koda-canary/deploys/686233c789045c0008a8f626 |
| Deploy Preview | https://deploy-preview-11572--koda-canary.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify project configuration.
Walkthrough
A new router options configuration file has been added to define custom scroll behavior for a Nuxt.js application, replacing the previous standalone scroll behavior script. The logic for handling scroll positions, including hash navigation and route-based scroll disabling, is now encapsulated within an exported configuration object.
Changes
| File(s) | Change Summary |
|---|---|
| app/router.options.ts | Added a configuration file exporting a custom scroll behavior function and scroll behavior type. |
| app/router.scrollBehavior.js | Removed the previous standalone scroll behavior script and its helper function. |
Sequence Diagram(s)
sequenceDiagram
participant Router
participant ScrollBehavior
participant DOM
Router->>ScrollBehavior: On route navigation (to, from)
alt Route name in disable list
ScrollBehavior-->>Router: Return false (no scroll)
else Route has hash
ScrollBehavior->>DOM: findEl(hash)
alt Element found
ScrollBehavior->>DOM: Scroll to element (smooth or instant)
else Element not found
ScrollBehavior->>DOM: Scroll to #app
end
else No hash
ScrollBehavior->>DOM: Scroll to (0,0)
end
Poem
A hop and a scroll, the router's new role,
With smooth little jumps from hash to the goal.
Old scripts retire, new configs aspire,
To keep every click just as users desire.
🐇✨
✨ Finishing Touches
- [ ] 📝 Generate Docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
🪧 Tips
Chat
There are 3 ways to chat with CodeRabbit:
- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
I pushed a fix in commit <commit_id>, please review it.Explain this complex logic.Open a follow-up GitHub issue for this discussion.
- Files and specific lines of code (under the "Files changed" tab): Tag
@coderabbitaiin a new review comment at the desired location with your query. Examples:@coderabbitai explain this code block.@coderabbitai modularize this function.
- PR comments: Tag
@coderabbitaiin a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.@coderabbitai read src/utils.ts and explain its main purpose.@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.@coderabbitai help me debug CodeRabbit configuration file.
Support
Need help? Create a ticket on our support page for assistance with any issues or questions.
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
CodeRabbit Commands (Invoked using PR comments)
@coderabbitai pauseto pause the reviews on a PR.@coderabbitai resumeto resume the paused reviews.@coderabbitai reviewto trigger an incremental review. This is useful when automatic reviews are disabled for the repository.@coderabbitai full reviewto do a full review from scratch and review all the files again.@coderabbitai summaryto regenerate the summary of the PR.@coderabbitai generate docstringsto generate docstrings for this PR.@coderabbitai generate sequence diagramto generate a sequence diagram of the changes in this PR.@coderabbitai resolveresolve all the CodeRabbit review comments.@coderabbitai configurationto show the current CodeRabbit configuration for the repository.@coderabbitai helpto get help.
Other keywords and placeholders
- Add
@coderabbitai ignoreanywhere in the PR description to prevent this PR from being reviewed. - Add
@coderabbitai summaryto generate the high-level summary at a specific location in the PR description. - Add
@coderabbitaianywhere in the PR title to generate the title automatically.
CodeRabbit Configuration File (.coderabbit.yaml)
- You can programmatically configure CodeRabbit by adding a
.coderabbit.yamlfile to the root of your repository. - Please see the configuration documentation for more information.
- If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation:
# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Documentation and Community
- Visit our Documentation for detailed information on how to use CodeRabbit.
- Join our Discord Community to get help, request features, and share feedback.
- Follow us on X/Twitter for updates and announcements.
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code