nft-gallery icon indicating copy to clipboard operation
nft-gallery copied to clipboard

fix: minted count

Open preschian opened this issue 1 year ago • 3 comments

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • [x] Bugfix
  • [ ] Feature
  • [ ] Refactoring

Context

  • [x] Closes #10901
  • [x] Closes #10904
  • [x] Closes #10914
  • [x] Requires worker deployment https://github.com/kodadot/private-workers/pull/213

Did your issue had any of the "$" label on it?

preschian avatar Aug 26 '24 06:08 preschian

Deploy Preview for koda-canary ready!

Name Link
Latest commit 8f1ce5ea244987ced342a0c3b75dd7ca1704f270
Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/66e0143af262ad00081e1269
Deploy Preview https://deploy-preview-10903--koda-canary.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Aug 26 '24 07:08 netlify[bot]

Deploying koda-art-prod with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8f1ce5e
Status: ✅  Deploy successful!
Preview URL: https://6d7c9a81.kodaart-production.pages.dev
Branch Preview URL: https://refactor--unused-drops-compo.kodaart-production.pages.dev

View logs

It may not be related to this issue.

After I minted a drop, the number of minted does not update. I have to refresh the page to see the correct number.

image

Jarsen136 avatar Aug 30 '24 12:08 Jarsen136

It may not be related to this issue.

After I minted a drop, the number of minted does not update. I have to refresh the page to see the correct number.

this is really good point and related to this PR hopefully it can clear the issue if we add popup message like this. let me ask Exec first (the popup is from fxhash)

E62CB9F8-22F0-4C48-A10C-D78BF7BA8A35_1_105_c

preschian avatar Sep 02 '24 07:09 preschian

Changes:

  • Adjust carousel drops to align with ops-internal discussion #1845. Additionally, show minted drops on the carousel. Because, if all of the drops already minted out, it will shows blank
  • Remove useDrops() composable. Use getDrops() directly.
  • Replace useCollectionActivity() usage with oda-worker to get owner address on DropCard related components:
    • Reason: useCollectionActivity() composable is computationally heavy on the client side.
    • Impact: When switching chains, it was noticeably laggy on localhost.
  • Add toast message when claiming drops is successful:
    • Purpose: To provide more information to users about the delay in seeing the drops on the website.
    • Reference: PR #10903 comment
  • Remove drop.location usage:
    • Rationale: Seems to be rarely used. Can be added back if needed in the future.
  • Refactor some useDrops() composable to drops/utils.ts
  • Remove Drop interface, adjust DropItem instead
  • Remove unused Unlockable components

preschian avatar Sep 09 '24 07:09 preschian

cc @Jarsen136

vikiival avatar Sep 09 '24 12:09 vikiival

remedy for - #10958

vikiival avatar Sep 10 '24 09:09 vikiival