nft-gallery icon indicating copy to clipboard operation
nft-gallery copied to clipboard

Fix/click see all search

Open codomposer opened this issue 1 year ago • 6 comments

Thank you for your contribution to the Koda - Generative Art Marketplace.

👇 __ Let's make a quick check before the contribution.

PR Type

  • [x] Bugfix
  • [ ] Feature
  • [ ] Refactoring

Context

  • [x] Closes #<10650> https://github.com/kodadot/nft-gallery/issues/10650

Screenshot 📸

image image image

codomposer avatar Jul 29 '24 13:07 codomposer

Deploy Preview for koda-canary ready!

Name Link
Latest commit 15b04ef30787ff80e3f13fdbe89383ed14698eb2
Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/66a9c3eba91ba00008845a5c
Deploy Preview https://deploy-preview-10704--koda-canary.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jul 29 '24 13:07 netlify[bot]

it does not redirect to the explorer when first hitting the enter - its the first search i made on the page image

looks like edge case, could you please investigate?

exezbcz avatar Jul 31 '24 08:07 exezbcz

The functionality is working correctly. However, before getting all JavaScript and asset files, it does not function as expected. So, we need to wait to get all bundled files

codomposer avatar Jul 31 '24 09:07 codomposer

second review? @kodadot/internal-dev

exezbcz avatar Aug 07 '24 12:08 exezbcz

https://github.com/kodadot/nft-gallery/issues/10650

codomposer avatar Aug 07 '24 12:08 codomposer

Thank you for your contribution! Seems that issue was not merged for one month, therefore I am closing that as stale. Please pickup other p1/p2 issue ^-^.

vikiival avatar Sep 06 '24 09:09 vikiival