nft-gallery
nft-gallery copied to clipboard
Remove giant squid from the code
Thank you for your contribution to the Koda - Generative Art Marketplace.
👇 __ Let's make a quick check before the contribution.
PR Type
- [x] Bugfix
- [x] Refactoring
Needs QA check
- @kodadot/qa-guild please review
Context
- [x] Closes #10268
- replace on-chain identity with profile data
- remove giant squid request
- remove the
identity
setting page completely - performance: batch request several profiles data in one request https://github.com/kodadot/private-workers/pull/156
- Clean the console log for profile request https://github.com/kodadot/private-workers/pull/159
Did your issue had any of the "$" label on it?
- [x] My DOT address: Payout
Screenshot 📸
- [x] My fix has changed something on UI; a screenshot is best to understand changes for others.
Deploy Preview for koda-canary ready!
Name | Link |
---|---|
Latest commit | 6aea0b66c04f6241a22fda9cf44b70cb6c55e8b0 |
Latest deploy log | https://app.netlify.com/sites/koda-canary/deploys/664a7f6faddf320008835093 |
Deploy Preview | https://deploy-preview-10299--koda-canary.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Code Climate has analyzed commit bcce23e and detected 2 issues on this pull request.
Here's the issue category breakdown:
Category Count Duplication 2 View more on Code Climate.
It's the wrong analysis from codeclimate. Let's ignore it.
tests can be ignored as well, twitter changed itself to x
i'm checking the other errors
getting some different errors now:
getting some different errors now:
not sure errors is the right word here
these profiles simply don't exist
getting some different errors now:
not sure errors is the right word here
these profiles simply don't exist
Yup. It's the expected response result with a 404 status code, so it's not a real "error".
However, if we would like to make the console look more clean without showing any request 404 code, I will simply change the 404 code to 200 and return null
value. Only applied for API of /profile/:address
because it should be called lots of times. In this way, we could "hide" the 404 request error from the console.
https://github.com/kodadot/private-workers/pull/159
getting some different errors now:
not sure errors is the right word here these profiles simply don't exist
Yup. It's the expected response result with a 404 status code, so it's not a real "error".
However, if we would like to make the console look more clean without showing any request 404 code, I will simply change the 404 code to 200 and return
null
value. Only applied for API of/profile/:address
because it should be called lots of times. In this way, we could "hide" the 404 request error from the console.
✅ https://github.com/kodadot/private-workers/pull/159 Deployed and also removed the error log from the console
Code Climate has analyzed commit 6aea0b66 and detected 2 issues on this pull request.
Here's the issue category breakdown:
Category | Count |
---|---|
Duplication | 2 |
View more on Code Climate.
Quality Gate passed
Issues
1 New issue
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code
can benefit from caching
rest is kinda minor
Thanks! I have updated them.
@Jarsen136 you may want to look at #10323
@Jarsen136 you may want to look at #10323
https://github.com/kodadot/nft-gallery/issues/10324 It could be done first.
@vikiival How about merging it ?
Is it somehow cached?
Is it somehow cached?
It's already cached but not ideal. Ideally, It needs a better fetching library with cache. Should I implement it at the current PR also? https://github.com/kodadot/nft-gallery/discussions/10329