nft-gallery
nft-gallery copied to clipboard
feat: Display success message after transaction is in block
PR Type
- [ ] Bugfix
- [x] Feature
- [ ] Refactoring
Context
changed normal and auto-teleport flow of:
- create collection
- buy nft
- list nft
@prury pls test all these flows
note: mint drop will be a follow up, blocked by
- [x] Closes #10231
Needs QA check
- @kodadot/qa-guild please review
Needs Design check
- @exezbcz please review
Did your issue had any of the "$" label on it?
- [x] Fill up your DOT address: Payout
Screenshot 📸
- [x] My fix has changed something on UI;
buy
normal
https://github.com/kodadot/nft-gallery/assets/44554284/769e81e1-e2ed-4f83-8c67-971b4312e51d
autotelport
https://github.com/kodadot/nft-gallery/assets/44554284/d5bb9d73-3efc-465c-bbbd-61ae3297d3f6
create collection with autotelport
https://github.com/kodadot/nft-gallery/assets/44554284/bb11ac32-94d4-41c0-acab-5f3fc901ff77
listing cart autoteleport
https://github.com/kodadot/nft-gallery/assets/44554284/13d895f8-e0a3-4ffe-9b11-d066f4b2ea30
Deploy Preview for koda-canary ready!
Name | Link |
---|---|
Latest commit | e74a0491980b8cf5b1349c31ce37416fd015acb1 |
Latest deploy log | https://app.netlify.com/sites/koda-canary/deploys/6645d4c547256b0008759794 |
Deploy Preview | https://deploy-preview-10293--koda-canary.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Code Climate has analyzed commit e74a0491 and detected 3 issues on this pull request.
Here's the issue category breakdown:
Category | Count |
---|---|
Complexity | 1 |
Duplication | 2 |
View more on Code Climate.
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code
superb testing @hassnian!
only i could not test was collection creation, as success modal does not open here for me(issue opened), but the other interactions work fine. And i guess for NFT creation we still don't show success modal?
And i guess for NFT creation we still don't show success modal?
nope we don't have that one implemented, I guess it would be the same as the successful drop modal . cc @exezbcz
cc @preschian can you please review?