nft-gallery icon indicating copy to clipboard operation
nft-gallery copied to clipboard

feat: Display success message after transaction is in block

Open hassnian opened this issue 9 months ago • 6 comments

PR Type

  • [ ] Bugfix
  • [x] Feature
  • [ ] Refactoring

Context

changed normal and auto-teleport flow of:

  • create collection
  • buy nft
  • list nft

@prury pls test all these flows

note: mint drop will be a follow up, blocked by

  • [x] Closes #10231

Needs QA check

  • @kodadot/qa-guild please review

Needs Design check

  • @exezbcz please review

Did your issue had any of the "$" label on it?

  • [x] Fill up your DOT address: Payout

Screenshot 📸

  • [x] My fix has changed something on UI;

buy

normal

https://github.com/kodadot/nft-gallery/assets/44554284/769e81e1-e2ed-4f83-8c67-971b4312e51d

autotelport

https://github.com/kodadot/nft-gallery/assets/44554284/d5bb9d73-3efc-465c-bbbd-61ae3297d3f6

create collection with autotelport

https://github.com/kodadot/nft-gallery/assets/44554284/bb11ac32-94d4-41c0-acab-5f3fc901ff77

listing cart autoteleport

https://github.com/kodadot/nft-gallery/assets/44554284/13d895f8-e0a3-4ffe-9b11-d066f4b2ea30

hassnian avatar May 14 '24 11:05 hassnian

Deploy Preview for koda-canary ready!

Name Link
Latest commit e74a0491980b8cf5b1349c31ce37416fd015acb1
Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6645d4c547256b0008759794
Deploy Preview https://deploy-preview-10293--koda-canary.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar May 14 '24 11:05 netlify[bot]

Code Climate has analyzed commit e74a0491 and detected 3 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1
Duplication 2

View more on Code Climate.

codeclimate[bot] avatar May 16 '24 09:05 codeclimate[bot]

superb testing @hassnian!

prury avatar May 16 '24 18:05 prury

only i could not test was collection creation, as success modal does not open here for me(issue opened), but the other interactions work fine. And i guess for NFT creation we still don't show success modal?

prury avatar May 16 '24 20:05 prury

And i guess for NFT creation we still don't show success modal?

nope we don't have that one implemented, I guess it would be the same as the successful drop modal . cc @exezbcz

hassnian avatar May 17 '24 04:05 hassnian

cc @preschian can you please review?

vikiival avatar May 21 '24 09:05 vikiival