nft-gallery icon indicating copy to clipboard operation
nft-gallery copied to clipboard

fix: Paid mint modal auto-teleport flow

Open hassnian opened this issue 9 months ago • 11 comments

PR Type

  • [x] Bugfix
  • [ ] Feature
  • [ ] Refactoring

Context

option 2 , have always one, once auto-teleport modal is open the below one is gone and once the teleport is done the other one appears with the success step

  1. paid mint auto-teleport flow changed (only one modal at a time)
  2. fix: minting session getting cleared on mint cancel when doing teleport

@prury pls test theses 3 flows

  • normal flow
  • autoteleport flow
  • mutiple autotelport in one session

I've attached bellow videos for each one , thanks

  • [x] Closes #10253

Needs QA check

  • @kodadot/qa-guild please review

Needs Design check

  • @exezbcz please review

Did your issue had any of the "$" label on it?

  • [x] Fill up your DOT address: Payout

Screenshot 📸

  • [x] My fix has changed something on UI;

paid mint auto teleport

https://github.com/kodadot/nft-gallery/assets/44554284/c2d8e919-0bbd-44c3-88ce-99befde27168

paid mint normal flow

https://github.com/kodadot/nft-gallery/assets/44554284/6b3a867f-366c-42b9-b1bf-81d0c1e1784b

testing multiple autotelport in one session

https://github.com/kodadot/nft-gallery/assets/44554284/5e7c5963-37c2-42ab-bbe1-d658dfbe198a

hassnian avatar May 07 '24 12:05 hassnian

Deploy Preview for koda-canary ready!

Name Link
Latest commit 65a7c3de686881966676cd67f07f1f5bc96b3891
Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/664b4fc82707d10008edf588
Deploy Preview https://deploy-preview-10258--koda-canary.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar May 07 '24 12:05 netlify[bot]

i was testing and normal flow went ok, but then i started facing issues with auto-teleport that we are solving in #10264 , let's wait for it to be merged. So far one modal at time was working ok

prury avatar May 08 '24 19:05 prury

i was testing and normal flow went ok, but then i started facing issues with auto-teleport that we are solving in #10264 , let's wait for it to be merged. So far one modal at time was working ok

What drop are you using to do the tests ? I tested it with meadow and worked fine , didn't face that issue once

#10264 it's only happening with hdd drop isn't ?

These two issue are not related , and should be able to be solved independently , but we can wait.

Is the balance check issue also happening in other drops ?

hassnian avatar May 09 '24 06:05 hassnian

These two issue are not related , and should be able to be solved independently , but we can wait.

Is the balance check issue also happening in other drops ?

sorry for the lack of info, but yes, it also happened on meadow.

prury avatar May 09 '24 12:05 prury

cc @daiagi

vikiival avatar May 14 '24 10:05 vikiival

cc @prury ?

vikiival avatar May 15 '24 11:05 vikiival

Code Climate has analyzed commit 09fc7374 and detected 0 issues on this pull request.

View more on Code Climate.

codeclimate[bot] avatar May 16 '24 12:05 codeclimate[bot]

cc @prury ?

i was OOO but now i can test this one properly as the other two PRs needed have been merged

prury avatar May 16 '24 12:05 prury

@hassnian i think we are good, only thing i was found uncommon was loading modal between some steps(1:56), but its coming from canary, so.

overlapping modals seems to be solved, and modals seems to be appearing in right places at the right time. no closing when transaction is cancelled

whole autoteleport + autoteleport process:

Gravação de tela de 16-05-2024 10:25:55.webm

prury avatar May 16 '24 14:05 prury

@JustLuuuu can u please check?

vikiival avatar May 16 '24 15:05 vikiival

I think its ok

JustLuuuu avatar May 20 '24 12:05 JustLuuuu