NoteBlockAPI icon indicating copy to clipboard operation
NoteBlockAPI copied to clipboard

MIDI file playback support

Open ishland opened this issue 4 years ago • 6 comments

Closes #24

ishland avatar Aug 23 '20 10:08 ishland

Is this currently implemented in any player for testing or just API additions for future use?

Edit: Assuming not yet, but if @koca2000 can merge the PR (if it's ready), MusicBox plugin would be one of the first to implement testing support once merged.

mibby avatar Feb 02 '21 18:02 mibby

Is this currently implemented in any player for testing or just API additions for future use?

It is currently implemented and works just fine in my testings. Currently theres are still some apis which is not working when playing midi files but I am working on it.

ishland avatar Feb 04 '21 05:02 ishland

I was just more curious if there was a front-end player that supported the API changes already. When I did some testing, various plugins (such as MusicBox) seemed to break due to API changes, so I'll probably just wait until it's merged into the main branch before testing midi support again.

mibby avatar Feb 05 '21 03:02 mibby

I was just more curious if there was a front-end player that supported the API changes already. When I did some testing, various plugins (such as MusicBox) seemed to break due to API changes, so I'll probably just wait until it's merged into the main branch before testing midi support again.

I got a modified JukeBox plugin here. jukebox.zip

ishland avatar Feb 05 '21 09:02 ishland

I was just more curious if there was a front-end player that supported the API changes already. When I did some testing, various plugins (such as MusicBox) seemed to break due to API changes, so I'll probably just wait until it's merged into the main branch before testing midi support again.

Hi! This is just one of the possible variants of implementation. The final change won't break other plugins.

koca2000 avatar Feb 05 '21 11:02 koca2000