clamby icon indicating copy to clipboard operation
clamby copied to clipboard

[FEATURE] Extract virus details and include in VirusDetected

Open abrom opened this issue 3 years ago • 2 comments

Great gem @kobaltz thanks!

I've got a requirement to display the type of virus that has been detected. I've already written the changes needed to add this to clamby but thought I'd check if that would be something you'd be interested in merging before creating the PR.

Basically just modifying the Command class, specifically the .scan and #run methods to parse the console output and include the parsed virus type when raising the VirusDetected error. My change swaps out the system call with a Open3 library function call to peek at the output and error streams.

Thoughts?

abrom avatar Oct 25 '21 15:10 abrom

i.e.

https://github.com/kobaltz/clamby/compare/master...abrom:add-virus-type-parser

abrom avatar Nov 02 '21 00:11 abrom

I've been waiting for this feature foreverrrr

arianf avatar Jan 12 '22 21:01 arianf