kobalte
kobalte copied to clipboard
kobaltedev
feat: stepper component added
Deploy Preview for kobalte ready!
| Name | Link |
|---|---|
| Latest commit | |
| Latest deploy log | https://app.netlify.com/sites/kobalte/deploys/673bbae8938ade42f8530ccc |
| Deploy Preview | https://deploy-preview-523--kobalte.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
Thanks for the PR!
There's a few changes needed around accessibility, mostly using a
<Tabs>component internally instead of re-implementing them.
Thanks for the detailed review. I've push the new commit and used the Tabs component internally. could you please go through new changes.
The previous button is not functioning correctly. When at step 1, it works as expected. However, when navigating to step 2 and then clicking previous, instead of returning to step 1, it moves to step 3.
The previous button is not functioning correctly. When at step 1, it works as expected. However, when navigating to step 2 and then clicking previous, instead of returning to step 1, it moves to step 3.
its old deployment, I've fixed it in new commits.
Why are there two components Stepper.Item and Stepper.Trigger? Can't they be combined into one? Stepper.Item also gets confused with Stepper.Content
In the form example the "Enter" key is ignored. I think this is an accessibility issue
What do you think about introducing something like onBeforeStepChange? This will allow us to handle step validation easier. We could listen to this event inside a specific step component and compare the current index with the step index. This way we can move all the validation logic to each individual step, which will help us eliminate long components. As a result, we will wrap each step component in a separate wrapper. This is very useful in complex forms.
Or you can add events to the step component directly, so you don't need to compare the index each time. This is a cool feature for end users and extensibility.
By using onBeforeStepChange you can cancel navigation programmatically and thus indicate that something is wrong with the current step.
