amdtweak icon indicating copy to clipboard operation
amdtweak copied to clipboard

Missing some info about "--read_file_pp" usage

Open Lucie2A opened this issue 7 years ago • 2 comments

After some check in code, you should document usage of method __read_file_pp.

when doing something like this :

./amdtweak --verbose --read-file-pp ../pp_tables/card_0.raw_pp_table --print

it doesn't do anything because __read_file_pp() doesn't allocate memory, nor buildup any card index list / structure to load data into it from the user provided file.

./amdtweak --verbose --card 0 --read-file-pp ../pp_tables/card_0.raw_pp_table --print

do work as method __card() has been called and so there is some memory where to put the data from the user provided file.

Possible fix:

  • document the expected behavior
  • issue an error when __read_file_pp() is called without any allocated memory
  • add a check in __read_file_pp() before to load user provided file and allocate required data structure, memory etc..., with a call to __card() or something similar.

best regards,

Lucie2A avatar Jan 04 '18 19:01 Lucie2A

Today I added a bit more to handle this, it's no longer required to specify card when reading an external pp file. Not sure it's ideal now, but it's a bit better than it was before. I also turned on verbosity by default and added --quiet option as well, hope that makes it better a bit.

kobalicek avatar Jan 08 '18 02:01 kobalicek

Let me know if this is okay now or whether it requires some more tweaking

kobalicek avatar Jan 25 '18 00:01 kobalicek