amdtweak
amdtweak copied to clipboard
Add VEGA10 chip support (RX-VEGA 56/64)
Add VEGA10 chip support (RX-VEGA 56/64) Add RX-560 and RX-VEGA64 pp_table samples
As I have not understand how to make a rebase with GIT, I have delete my repo and I have re-fork your master branch, fixed/updated code and then re-pull.
It may seams stupid, so if you can send me the basic cmd to rebase for next update it will be nice. (yes I DO have 'google' it several times...)
Best regards,
Samuel
Sorry for inactivity, I will take a look soon
Okay, I have few notes / comments:
- Why to rename
SocClockDependencyEntry
toSClockDependencyEntry
- both names are not exactly the same as the name inside the C structure. I normalized some structs, not sure it was right or wrong, but I would just keep theSoc
names as there are more fields etc that useSoc
and notS
. - Please use
//
comments, not C style comments (to have consistent comments across the file). - I just quickly looked into it, were any tables removed?
Please fix the first two and I can merge it, I didn't spot anything else. And thanks for the PR and sorry for late reply, I'm currently busy with one my other project.
Hi,
There was a reason for SClock* versus SocClock*. I need to check it again an explain it you why.
ok, no problem.
I remove some part of code that where not useful, but no pp_tables where disabled, no functionality where lost.