Toru Kobayashi

Results 102 comments of Toru Kobayashi

I've created a PR to support `getSnapshotBeforeUpdate` for `shallow` https://github.com/airbnb/enzyme/pull/1657

@sibasishm Could you reproduce it on CodeSandbox? Updating the SWR version might fix your issue.

@nevnein Yeah, as you mentioned, that's a stale closure problem. The `setSize` call in `modifyArray` references stale `getKey`, so it cannot get the result of `setCalls`. This seems to be...

@tomaszczura I've tried your test case. > Click 'Show details' and then 'Hide details' - displayed date is still the same At the step, the data has been updated because...

I guess your `useMatchMutate` implementation updates cache data incorrectly, because SWR stores some metadata in addition to cache data, and `useMatchMutate` seems to update the metadata not only cache data....

@tomaszczura > you create two entries incache: one with keyA and one with $inf$keyA. Our useMatchMutate updates the second one, but does not touch the first. This approach worked in...

@shuding Why did you add the `documentation` label in this? What documentation do you expect?

Thank you! I agree with you 👍 The documentation is very helpful.

`waitForDedupingInterval` that I've added depends on `sleep(1)` and `testing-library`'s `act`, so it doesn't make sense to expose this as a public API. But I think it's a good idea that...