scikit-lego icon indicating copy to clipboard operation
scikit-lego copied to clipboard

Published 20 hours ago • verified publisher icon koaning

[BUG] Warning message equal_opportunity_score does not correspond to actual condition

Open janvdvegt opened this issue 5 years ago • 1 comments

In the equal_opportunity_score there are two warnings that can be thrown when either y_given_z1_y1 or y_given_z0_y1 is empty. The warning messages say that there are no predictions with the positive target for the positive or negative sensitive columns, this does not need to be the case though because there is an additional filter with only the true positive samples.

f"No samples with y_hat == {positive_target} for {sensitive_column} == 1, returning 0"

could become

f"No samples with y_hat == {positive_target} for {sensitive_column} == 1 and y_true == {positive_target}, returning 0"

Same for the negative case.

janvdvegt avatar Oct 08 '20 11:10 janvdvegt

Adding extra information to an error message seems totally fine to me. Feel free to make the PR. @MBrouns, comments?

koaning avatar Oct 09 '20 06:10 koaning