mount icon indicating copy to clipboard operation
mount copied to clipboard

use path-to-regex for express-like mounted routes

Open jonathanong opened this issue 11 years ago • 8 comments

app.use(mount('/:id(\d+)', fn))

interested? path-to-regex does prefix routing. should be backwards compatible. not sure how i want to handle keys though. maybe (next, keys...)

jonathanong avatar Mar 25 '14 22:03 jonathanong

I can't think of too many cases where it would be useful, usually you can just do the same thing by rewriting the url to match the mount point, but I think even just concept of mounting being just like the mount command is nice, not sure that we need regexp support, the middleware wouldn't know how to act on the params

tj avatar Mar 25 '14 23:03 tj

this would be useful for nested resources. e.g. you have users that have posts and routes like:

/users/:id/posts/:id

and you wanna have two apps: a users app and a posts app - where the posts app is mounted in the users app.

there's no good way to do this currently (i think?) since the posts app would be mounted at /:id/posts.

travisjeffery avatar Oct 02 '14 23:10 travisjeffery

:+1: on this request

bilalaslam avatar Nov 07 '14 06:11 bilalaslam

+1

matthewmueller avatar Nov 07 '14 10:11 matthewmueller

:+1:

lazdmx avatar Mar 31 '15 10:03 lazdmx

I'm also for this! I often need to compose several sub-applications where one sub-application just needs to take all the paths that are not covered by the other ones. But I do want to have some shared things also.

Example:

import Koa   from 'koa'
import mount from 'koa-mount'

import api    from './subapps/api'
import html   from './subapps/html'
import logger from './tools/logger'

const app = new Koa();

// api is mounted under api (this is possible)
app.use(mount('/api', api));

// html is mounted at /, but isn't called when the path starts with /api
// this is currently not possible
app.use(mount(/^\/(?!api)/, html);  

// shared stuff
app.use(logger);

app.listen(3000);

I hope you see the validness of this use-case?

There's a workaround i'm currently using, but it is ugly. I just put this on top of every handler in the html route:

html.use(function (ctx, next) {
  if (/^\/(api)/.test(ctx.url)) { return next(); }
  //... 
});

But this is becoming very tedious to maintain. It'd be better to have all the paths in one location.

romeovs avatar Dec 12 '15 14:12 romeovs

+1

anupnitkkr avatar Nov 06 '19 08:11 anupnitkkr

with different baseurl, I need to add all route with this mount method

anupnitkkr avatar Nov 06 '19 08:11 anupnitkkr