koa icon indicating copy to clipboard operation
koa copied to clipboard

fix: parse port in x-forwarded-for (#827)

Open jasonmacgowan opened this issue 6 years ago • 2 comments

Parses out IPs even if a port is sent in x-forwarded-for for IPv4. Probably fails if port is sent with an IPv6 address, but works otherwise.

fixes #827

jasonmacgowan avatar Jun 14 '18 18:06 jasonmacgowan

Codecov Report

Merging #1205 into master will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1205   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          487       494    +7     
  Branches       136       135    -1     
=========================================
+ Hits           487       494    +7     
Impacted Files Coverage Δ
lib/request.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d1c9263...d2a2714. Read the comment docs.

codecov[bot] avatar Jun 14 '18 18:06 codecov[bot]

Looks like @3imed-jaberi is going to be unavailable for a while based on his profile.

Anyone else around to take a look at this?

/cc @jonathanong @dougwilson

jasonmacgowan avatar Aug 17 '20 19:08 jasonmacgowan