ko icon indicating copy to clipboard operation
ko copied to clipboard

UISkillTree out of pages and slots

Open UTengine opened this issue 8 months ago • 0 comments

Search before asking

  • [x] I searched the issues and found no similar issues.

Description

We are out of pages for skills next page doesn't work. Image

Expected Behaviour

I have no clue but we could add 1 extra page which should suffice for now... const int MAX_SKILL_PAGE_NUM = 4; // 스킬 한개가 가지는 최대 페이지수..

void CUISkillTreeDlg::PageLeft() {
    if (m_iCurSkillPage == 0) {
        return;
    }

    SetPageInIconRegion(m_iCurKindOf, m_iCurSkillPage - 1);
}

void CUISkillTreeDlg::PageRight() {
    if (m_iCurSkillPage == 3) {
        return;
    }

    SetPageInIconRegion(m_iCurKindOf, m_iCurSkillPage + 1);
}

Image Image

Observed Behaviour

const int MAX_SKILL_PAGE_NUM = 3; // 스킬 한개가 가지는 최대 페이지수..

void CUISkillTreeDlg::PageLeft() {
    if (m_iCurSkillPage == 0) {
        return;
    }

    SetPageInIconRegion(m_iCurKindOf, m_iCurSkillPage - 1);
}

void CUISkillTreeDlg::PageRight() {
    if (m_iCurSkillPage == 2) {
        return;
    }

    SetPageInIconRegion(m_iCurKindOf, m_iCurSkillPage + 1);
}

How to reproduce

Using 12xx magic main tables some classes and categories can't show all skills this wasn't an issue with the older UIF's and design since they had more Icon slots and pages were limited to only 3. But when we updated the UIF's to 12xx this created a bug

Are you willing to work on and submit a PR to address the issue?

  • [x] Yes I am willing to submit a PR!

UTengine avatar Apr 26 '25 14:04 UTengine