Raphael 'kena' Poss

Results 182 comments of Raphael 'kena' Poss

NB: if you're interested I could pull the functionality out of bubbline into a PR for bubbletea. Let me know.

> since we already have a default signal handler, we should probably strive to support SIGSTP as well. It's the other way around: the process does not handle SIGTSTP itself...

SIGTSTP only works if the process does _not_ catch it in its signal handler. So I think the existing signal handling is fine to support suspend properly.

Yes do not use regexps as this indeed would be too slow. What about a new API next to `SetHeader` called `SetColumnAlignment`, taking an array of alignment characters, one per...

Maybe this is true, unsure? Feel free to try it out, demonstrate with a screencast this is indeed true, and send a PR with the change. Note that this package...

See https://github.com/cockroachdb/c-rocksdb/pull/12 And also https://github.com/cockroachdb/c-rocksdb/commit/4d67cb2d76c14b7d117fbcd95fa9586b7b92e048

What do you think? I was missing a way to properly test all the features of the `datadriven` package. I think this way we can do this. If you think...

> Couldn't we change the infrastructure to take a testing.TB and provide an instrumented implementation for the purposes of testing? That was my first idea actually, but I found it...

> you'd just intercept some of the calls we care about (Error,Fatal). I might be missing some subtleties though I'd like to understand more: how do you mock something that...