flip-link icon indicating copy to clipboard operation
flip-link copied to clipboard

Published 20 hours ago • verified publisher icon knurling-rs

fix handling of multiline comments

Open alex-tdrn opened this issue 9 months ago • 2 comments

Fixes #116 by stripping multiline comments using the regex crate

alex-tdrn avatar Feb 23 '25 12:02 alex-tdrn

just realized that my solution can change the line count in the linker script, so the line index found by find_ram_in_linker_script is wrong

alex-tdrn avatar Feb 23 '25 12:02 alex-tdrn

I don't love having to use regular expressions here, but it does appear to resolve the issue.

Thoughts @Urhengulas? I'm minded to approve.

jonathanpallant avatar Feb 26 '25 10:02 jonathanpallant