defmt icon indicating copy to clipboard operation
defmt copied to clipboard

Allow bitflags v1 and v2 to coexist

Open manushT opened this issue 1 year ago • 6 comments

The patch breaks cargo's additive features

Fixes #877.

manushT avatar Nov 27 '24 16:11 manushT

Unfortunately this doesn't work because Library A might use defmt to describe some data type and expect the bitflags v1 API whilst Library B might use defmt but expect the bitflags v2 API (if we add it).

You could have a feature flag for bitflags v2 so that we keep the dependency list as short as possible, but it has to be additional and exported as a different macro with a different name.

jonathanpallant avatar Nov 27 '24 16:11 jonathanpallant

The CHANGELOG was reformatted. Can you rebase?

jonathanpallant avatar Nov 29 '24 13:11 jonathanpallant

The format check failed, I'm afraid.

jonathanpallant avatar Nov 29 '24 14:11 jonathanpallant

@manushT - we still have an outstanding comment on this one.

jonathanpallant avatar Jan 07 '25 14:01 jonathanpallant

There's still an outstanding question around importing and re-exporting the bitflags API so that people don't have to try and include the same version of bitflags in their application that defmt was using. I think that's a good idea.

jonathanpallant avatar Feb 26 '25 16:02 jonathanpallant