tokio-ping icon indicating copy to clipboard operation
tokio-ping copied to clipboard

Published 20 hours ago • verified publisher icon knsd

New futures

Open usbalbin opened this issue 5 years ago • 3 comments

I have converted from 0.1 futures and tokio 0.1 to std futures with async await and tokio 0.2. However to use async/await I had to convert to the 2018 edition which probably is done better in #12

usbalbin avatar Jan 27 '20 11:01 usbalbin

hey is there anything left to do in order to merge this?

agrinman avatar Jun 30 '20 13:06 agrinman

@agrinman oh, I almost forgot about this PR. I sort of turned my focus towards #14 (rebase of #12) which is focused on the edition change. Therefore I kind of planned for #14 to be merged first and then deal with the conflicts in this PR.

However, if someone wants this to be merged first/instead of #14 then I'll be happy to try to make sure this PR ready. As far as I can remember it should already be ready, however I should probably have an extra look.

usbalbin avatar Jun 30 '20 20:06 usbalbin

if someone wants this to be merged first

That'd be nice! I'm on day two of learning Rust, thought I'd have a go at pinging something, and this threw me for a bit of a loop 😅

Appreciate your efforts regardless, though!

gdyr avatar Jul 09 '20 08:07 gdyr