XChart
XChart copied to clipboard
Draw real text rather than text shapes
This pull request contains changes suggested in issue #499
Thanks. Did you test this good and look at all the charts in XChartDemo?
Thanks. Did you test this good and look at all the charts in XChartDemo?
Honestly, no. I was wondering how you test your changes, I did not find any regression tests in the library. I have only tested the integration in our software, which is a work in progress and does not cover everything yet. Also, I did some more changes in my fork of the library in the meanwhile, including some refactoring to get rid of warnings in Eclipse. So it was not so easy to create the pull request containing just the relevant changes.
I am still wondering what was your original reasoning to use the text outlines instead of drawing text and whether a change like this might annoy your users. E.g. when producing an SVG, an outline shape is safe to look the same everywhere. If you print text instead, the SVG will be smaller and the text will be readable in it, but it might look differently depending on whether or not the given font is available in the system where you look at the SVG (unless you embed the font into the SVG).