Incorrect parameter order in engine.cancelOrder method

[mojtabye]

In the current implementation of SimulatedExchnage at this line, the call to engine.cancelOrder uses the wrong argument order:

engine.cancelOrder(orderId, getApiKey(), type); It should be: engine.cancelOrder(getApiKey(), orderId, type);

This causes cancellation requests to fail or behave unexpectedly. This issue proposes fixing the argument order to match the expected method signature.

[mojtabye]

I tried to create a pull request to contribute a fix for this issue, but it seems I don’t have the necessary access. Could you please let me know how I can start contributing to the project?

[gewure]

@timmolter

[bigscoop]

you can create a branch in your fork, make changes there and then create a pull request in this repo