XChange icon indicating copy to clipboard operation
XChange copied to clipboard

TradeOgreAdapters.adaptCurrencyPair() build a wrong CurrencyPair

Open francitoshi opened this issue 1 year ago • 2 comments

class "TradeOgreAdapters" has the method "adaptCurrencyPair" with

return currencyPair.counter.toString() + "-" + currencyPair.base.toString();

but shoud be

return currencyPair.base.toString() + "-" + currencyPair.counter.toString();

This bug prevents applications from placing an order, with this change the problem it's solved.

francitoshi avatar May 07 '24 08:05 francitoshi

please create a PR @francitoshi !

gewure avatar May 15 '24 10:05 gewure

it is this one https://github.com/knowm/XChange/pull/4871

bigscoop avatar May 15 '24 10:05 bigscoop