XChange icon indicating copy to clipboard operation
XChange copied to clipboard

[binance] Add tickers

Open bigscoop opened this issue 9 months ago • 6 comments

  • Added mapping symbol -> currency pair (got from exchange info)
  • Moved exchangeInfo-methods to MarketDataService
  • Updated integration tests
  • Added requests for idea http client
  • Simplified dto's

bigscoop avatar Apr 29 '24 18:04 bigscoop

Hi. Two requests for tickers: api/v3/ticker/price - Latest price for a symbol or symbols. api/v3/ticker/bookTicker - Best price/qty on the order book for a symbol or symbols. But there is no volume and quoteVolume and ticker time is only last moment.

If I understand correctly, we should get a 24 hour ticker. this api is fit: https://binance-docs.github.io/apidocs/spot/en/#24hr-ticker-price-change-statistics

rizer1980 avatar May 03 '24 16:05 rizer1980

Hi. Two requests for tickers: api/v3/ticker/price - Latest price for a symbol or symbols. api/v3/ticker/bookTicker - Best price/qty on the order book for a symbol or symbols. But there is no volume and quoteVolume and ticker time is only last moment.

If I understand correctly, we should get a 24 hour ticker. this api is fit: https://binance-docs.github.io/apidocs/spot/en/#24hr-ticker-price-change-statistics

Hi. Yep, good idea :+1: will change the implementation

bigscoop avatar May 04 '24 20:05 bigscoop

done #4868

rizer1980 avatar May 04 '24 21:05 rizer1980

@timmolter

I propose to review and merge the https://github.com/knowm/XChange/pull/4868 first. Then I can integrate the changes to my branch

bigscoop avatar May 04 '24 22:05 bigscoop

merged 4868

timmolter avatar May 05 '24 09:05 timmolter

merged 4868

done, feel free to review

bigscoop avatar May 10 '24 11:05 bigscoop

@timmolter ping

bigscoop avatar May 20 '24 19:05 bigscoop