XChange icon indicating copy to clipboard operation
XChange copied to clipboard

BINANCE FUTURE exchangeMetaData, need some advise

Open rizer1980 opened this issue 1 year ago • 0 comments

Hello. When we set 'SPECIFIC_PARAM_FUTURES_ENABLED = true' and create Future Binance exchange: according to this code in remoteInit()

@makarid

if(usingSandbox()){
        if(isFuturesSandbox()){
          BinanceAdapters.adaptFutureExchangeMetaData(exchangeMetaData, marketDataService.getFutureExchangeInfo());
        } else {
          exchangeMetaData = BinanceAdapters.adaptExchangeMetaData(marketDataService.getExchangeInfo(), assetDetailMap);
        }
      } else {
        exchangeMetaData = BinanceAdapters.adaptExchangeMetaData(marketDataService.getExchangeInfo(), assetDetailMap);
        if(isFuturesEnabled()){
          BinanceAdapters.adaptFutureExchangeMetaData(exchangeMetaData, marketDataService.getFutureExchangeInfo());
        }
      }

we save in exchangeMetaData all currency pair from Binance Spot and after all futurecontract from Future. same behavoir in Okx. I think this is wrong, if we use Future we should receive only related Instruments. spot - only currency pair future - only future instruments.

Tell me, if I'm right, I'll fix it.

rizer1980 avatar Dec 01 '23 13:12 rizer1980