XChange icon indicating copy to clipboard operation
XChange copied to clipboard
verified publisher icon knowm

4779_make_getmac_threadsafe

Open douggie opened this issue 2 years ago • 5 comments

https://github.com/knowm/XChange/issues/4779

douggie avatar Oct 16 '23 08:10 douggie

These test failures are unrelated, seems like an issue with develop.

douggie avatar Oct 16 '23 10:10 douggie

it's seems that some error in(kraken futures)

  1. no BTC in https://futures.kraken.com/derivatives/api/v3/instruments response (very strange)
  2. lower case parsing "pf" prefix in adaptInstrumentsMetaData method trying to deep in... @makarid ?

rizer1980 avatar Nov 08 '23 14:11 rizer1980

I think I fixed it post PR a little bit later

rizer1980 avatar Nov 08 '23 14:11 rizer1980

done https://github.com/knowm/XChange/pull/4787

rizer1980 avatar Nov 08 '23 15:11 rizer1980

@douggie is this fix just in case? or is there code that does not work without this change?

rizer1980 avatar Nov 08 '23 16:11 rizer1980