XChange icon indicating copy to clipboard operation
XChange copied to clipboard

Binance streaming adapter buys and sells reversed

Open m1dnightc0der opened this issue 2 years ago • 2 comments

org.knowm.xchange.binance.BinanceAdapters has the following method, that sets weather the trade is a buy or sell.

Looking at the order flow, when the buyerMarketMaker=true means that buyer was the maker/seller was the taker, so we want to show this as a sell order as per other markets seems we do the reverse.

Ho

    return isBuyer ? OrderType.BID : OrderType.ASK;
  }```

as per 
https://dev.binance.vision/t/a-little-confusion-about-is-buyer-market-maker-part-of-trade-stream/5660

m1dnightc0der avatar Nov 17 '22 11:11 m1dnightc0der